feature: update media checkin to fix path bug and allow modules to set more media info #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t more media info - add `is_embedded` to media item table - remove `media_path` from media references table - create central media folder and link/copy all media - create html media folder and link/copy all html media - change sql inserts to use parameters - move media check in logic to single internal function - public media check functions point to internal - add output parameters to context - add force params to let modules set mime type, extension, created, modified
JamesHabben
added
bug
Collaborator
|
You just forgot to replace |
- determine original extracted file source path ahead of embedded split - set source_path from original file path
Collaborator
Author
|
new commit to resolve the db source path issue you mentioned to me. ready for review when you have a chance @Johann-PLW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_embeddedto media item tablemedia_pathfrom media references table