Skip to content

Conversation

@Maite2003
Copy link
Contributor

Refactoring: Timestamps and Argument Handling

This PR introduces two primary updates:

  1. Timestamp Correction: I removed the database conversion function (datetime(time/1000,'unixepoch')) from the query. Instead, we now pull the raw Unix timestamp and use convert_unix_ts_to_utc() in Python. Is this the approach we should use?
  2. Artifact Arguments: Updated artifact function signatures to accept a context object instead of individual parameters.

Minor adjustments were made to timestamp handling and source path reporting.
Updated the query to select the raw time value instead of converting it to datetime in SQL. The conversion to UTC datetime is now handled in Python using convert_unix_ts_to_utc.
@JamesHabben
Copy link
Collaborator

a couple things:

  1. theres a conflict on appConduit module. looks like @Johann-PLW got some changes in on this one while @Maite2003 was doing the same. this commit has an adjustment to the source_path return value that i think is better than what is currently in place.
  2. have you run the AMDSQLiteDB module against a test data set just to confirm the dates are getting properly converted?

@Maite2003
Copy link
Contributor Author

i don' have any test data for AMDSQLiteDB

@JamesHabben
Copy link
Collaborator

you can see there are some hits in test images here: https://github.com/abrignoni/iLEAPP/blob/main/admin/docs/filepath_search_summary.md

@Maite2003
Copy link
Contributor Author

Thanks for the link! Okay, so I think I'm just missing a step here. I can see the markdown file lists all the important file paths, but where do I find the actual test images or zips that have those files inside them?

@JamesHabben
Copy link
Collaborator

with the US Gov shutdown, some websites arent loading :(

here are a few pages that have lists of test images.

@stark4n6 any other suggestions since NIST is currently down?

@stark4n6
Copy link
Collaborator

@JamesHabben let me look, I think I made this parser so I think I actually had test files (either on my own test devices or from a sample)

@JamesHabben
Copy link
Collaborator

Most of these changes are pretty straight forward. The only parts that concern me are the dates to ensure we are using the correct function based on the source data. Once that is validated, I think this PR is good to merge.

@JamesHabben JamesHabben added the Artifact Module Update related to an artifact module label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Artifact Module Update related to an artifact module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants