Fix Bug #3616: Fix handling of 204 No Content responses for Microsoft Graph PATCH requests #3620
+43
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Graph PATCH requests This change fixes incorrect error handling when Microsoft Graph returns 204 No Content for successful PATCH operations. Previously, the client always enforced JSON object validation for PATCH responses. When Graph legitimately returned 204 No Content (with an empty response body), the client incorrectly treated the operation as a failure, generated a OneDriveException, and entered a retry loop. This update adjusts the response validation logic to correctly treat 204 No Content and empty response bodies as successful outcomes, while preserving strict JSON validation for responses that are expected to return JSON payloads. This resolves scenarios where the client would continuously retry a successful Graph API call, resulting in repeated log messages such as: Retrying the respective Microsoft Graph API call for Internal Thread ID No behavioural change occurs for genuine error responses.
* Clarify message based on feedback - this ensures the right message is being presented * Ensure message changes when --verbose is used
* Update patch() and consumers of patch() to flag if the JSON response needs to be validated or not * Update checking of response when a 204 generated
* Only save if the JSON response is a valid JSON object
Owner
Author
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Repository owner
locked and limited conversation to collaborators
Feb 6, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes incorrect error handling when Microsoft Graph returns 204 No Content for successful PATCH operations.
Previously, the client always enforced JSON object validation for PATCH responses. When Graph legitimately returned 204 No Content (with an empty response body), the client incorrectly treated the operation as a failure, generated a OneDriveException, and entered a retry loop.
This update adjusts the response validation logic to correctly treat 204 No Content and empty response bodies as successful outcomes, while preserving strict JSON validation for responses that are expected to return JSON payloads.
This resolves scenarios where the client would continuously retry a successful Graph API call, resulting in repeated log messages such as:
No behavioural change occurs for genuine error responses.