Skip to content

Conversation

@JonoYang
Copy link
Member

@JonoYang JonoYang commented May 4, 2022

This PR fixes the duplicaed dependency issues for pypi and npm packages from #2943 . I've also added code to stop the pypi assemble method from associating a top-level package to packages detected from the site-packages directory.

JonoYang added 3 commits May 4, 2022 16:16
    * Update test expectations

Signed-off-by: Jono Yang <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pombredanne pombredanne merged commit 4a7d036 into develop May 5, 2022
@pombredanne pombredanne deleted the duplicated-dependencies-package-results branch May 5, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants