Skip to content

Commit e3628ff

Browse files
fanciful-marmotabernier
authored andcommitted
Remove position rounding in CSS2DRenderer on Safari (mrdoob#24122)
* Remove position rounding in CSS2DRenderer Relates to issue mrdoob#21415 * Run build-examples
1 parent af99d35 commit e3628ff

File tree

2 files changed

+2
-21
lines changed

2 files changed

+2
-21
lines changed

examples/js/renderers/CSS2DRenderer.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -113,17 +113,7 @@
113113

114114
object.onBeforeRender( _this, scene, camera );
115115
const element = object.element;
116-
117-
if ( /apple/i.test( navigator.vendor ) ) {
118-
119-
// https://github.com/mrdoob/three.js/issues/21415
120-
element.style.transform = 'translate(-50%,-50%) translate(' + Math.round( _vector.x * _widthHalf + _widthHalf ) + 'px,' + Math.round( - _vector.y * _heightHalf + _heightHalf ) + 'px)';
121-
122-
} else {
123-
124-
element.style.transform = 'translate(-50%,-50%) translate(' + ( _vector.x * _widthHalf + _widthHalf ) + 'px,' + ( - _vector.y * _heightHalf + _heightHalf ) + 'px)';
125-
126-
}
116+
element.style.transform = 'translate(-50%,-50%) translate(' + ( _vector.x * _widthHalf + _widthHalf ) + 'px,' + ( - _vector.y * _heightHalf + _heightHalf ) + 'px)';
127117

128118
if ( element.parentNode !== domElement ) {
129119

examples/jsm/renderers/CSS2DRenderer.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -125,16 +125,7 @@ class CSS2DRenderer {
125125

126126
const element = object.element;
127127

128-
if ( /apple/i.test( navigator.vendor ) ) {
129-
130-
// https://github.com/mrdoob/three.js/issues/21415
131-
element.style.transform = 'translate(-50%,-50%) translate(' + Math.round( _vector.x * _widthHalf + _widthHalf ) + 'px,' + Math.round( - _vector.y * _heightHalf + _heightHalf ) + 'px)';
132-
133-
} else {
134-
135-
element.style.transform = 'translate(-50%,-50%) translate(' + ( _vector.x * _widthHalf + _widthHalf ) + 'px,' + ( - _vector.y * _heightHalf + _heightHalf ) + 'px)';
136-
137-
}
128+
element.style.transform = 'translate(-50%,-50%) translate(' + ( _vector.x * _widthHalf + _widthHalf ) + 'px,' + ( - _vector.y * _heightHalf + _heightHalf ) + 'px)';
138129

139130
if ( element.parentNode !== domElement ) {
140131

0 commit comments

Comments
 (0)