Handling Invalid CRM configuration gracefully (sonic-net#2109)

dgsudharsan · web-flow · commit b4b00031378a · 2022-01-12T07:52:53.000-08:00
*When CRM table contains some invalid configurations, the existing logic parses all field values above it and doesn't parse the field values below it. On hitting the unknown field, crm orch returns the execution leaving the crm database inconsistent. To handle this gracefully CRM orch will just log the unknown field and continue processing the fields below the unknown field.
Signed-off-by: Sudharsan Dhamal Gopalarathnam &lt;sudharsand@nvidia.com&gt;
diff --git a/orchagent/crmorch.cpp b/orchagent/crmorch.cpp
@@ -325,7 +325,6 @@ void CrmOrch::handleSetCommand(const string& key, const vector<FieldValueTuple>&
             else
             {
                 SWSS_LOG_ERROR("Failed to parse CRM %s configuration. Unknown attribute %s.\n", key.c_str(), field.c_str());
-                return;
             }
         }
         catch (const exception& e)

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,6 @@ void CrmOrch::handleSetCommand(const string& key, const vector<FieldValueTuple>&`
`325`	`325`	`else`
`326`	`326`	`{`
`327`	`327`	`SWSS_LOG_ERROR("Failed to parse CRM %s configuration. Unknown attribute %s.\n", key.c_str(), field.c_str());`
`328`		`- return;`
`329`	`328`	`}`
`330`	`329`	`}`
`331`	`330`	`catch (const exception& e)`