Add devclass validation

Author: mbtools

src/#apmg#cl_package_json_valid.clas.abap

@@ -111,6 +111,7 @@ CLASS /apmg/cl_package_json_valid IMPLEMENTATION.
     APPEND LINES OF lcl_validate=>validate_persons( manifest ) TO result.
     APPEND LINES OF lcl_validate=>validate_engines( manifest ) TO result.
     APPEND LINES OF lcl_validate=>validate_dependencies( manifest ) TO result.
+    APPEND LINES OF lcl_validate=>validate_devclass( manifest ) TO result.
 
   ENDMETHOD.
 

src/#apmg#cl_package_json_valid.clas.locals_imp.abap

@@ -32,6 +32,12 @@ CLASS lcl_validate DEFINITION.
       RETURNING
         VALUE(result) TYPE string_table.
 
+    CLASS-METHODS validate_devclass
+      IMPORTING
+        !manifest     TYPE /apmg/if_types=>ty_manifest
+      RETURNING
+        VALUE(result) TYPE string_table.
+
 ENDCLASS.
 
 CLASS lcl_validate IMPLEMENTATION.
@@ -250,4 +256,22 @@ CLASS lcl_validate IMPLEMENTATION.
 
   ENDMETHOD.
 
+  METHOD validate_devclass.
+
+    IF manifest-devclass-default IS NOT INITIAL AND
+      /apmg/cl_package_json_valid=>is_valid_sap_package( manifest-devclass-default ) = abap_false.
+      INSERT |Invalid default SAP package: { manifest-devclass-default }| INTO TABLE result.
+    ENDIF.
+
+    IF manifest-devclass-abap_language_version IS NOT INITIAL AND
+       manifest-devclass-abap_language_version <> zif_abapgit_dot_abapgit=>c_abap_language_version-undefined AND
+       manifest-devclass-abap_language_version <> zif_abapgit_dot_abapgit=>c_abap_language_version-ignore AND
+       manifest-devclass-abap_language_version <> zif_abapgit_dot_abapgit=>c_abap_language_version-standard AND
+       manifest-devclass-abap_language_version <> zif_abapgit_dot_abapgit=>c_abap_language_version-key_user AND
+       manifest-devclass-abap_language_version <> zif_abapgit_dot_abapgit=>c_abap_language_version-cloud_development.
+      INSERT |Invalid ABAP language version: { manifest-devclass-abap_language_version }| INTO TABLE result.
+    ENDIF.
+
+  ENDMETHOD.
+
 ENDCLASS.

src/#apmg#if_package_json.intf.abap

@@ -17,22 +17,23 @@ INTERFACE /apmg/if_package_json PUBLIC.
 
   TYPES:
     BEGIN OF ty_package,
-      key             TYPE /apmg/if_persist_apm=>ty_key,
-      package         TYPE devclass,
-      name            TYPE string,
-      version         TYPE string,
-      description     TYPE string,
-      type            TYPE string,
-      private         TYPE abap_bool,
-      changed_by      TYPE as4user,
-      changed_at      TYPE string,
-      changed_at_raw  TYPE timestampl,
-      bundle          TYPE abap_bool,
-      parent          TYPE devclass,
-      favorite        TYPE abap_bool, " settings
-      write_protected TYPE abap_bool, " settings
-      labels          TYPE string_table, " settings
-      instance        TYPE REF TO /apmg/if_package_json,
+      key                   TYPE /apmg/if_persist_apm=>ty_key,
+      package               TYPE devclass,
+      name                  TYPE string,
+      version               TYPE string,
+      description           TYPE string,
+      type                  TYPE string,
+      private               TYPE abap_bool,
+      changed_by            TYPE as4user,
+      changed_at            TYPE string,
+      changed_at_raw        TYPE timestampl,
+      bundle                TYPE abap_bool,
+      parent                TYPE devclass,
+      abap_language_version TYPE uccheck,
+      favorite              TYPE abap_bool, " settings
+      write_protected       TYPE abap_bool, " settings
+      labels                TYPE string_table, " settings
+      instance              TYPE REF TO /apmg/if_package_json,
     END OF ty_package,
     ty_packages TYPE STANDARD TABLE OF ty_package
       WITH NON-UNIQUE KEY primary_key COMPONENTS key