-
Notifications
You must be signed in to change notification settings - Fork 488
feat: Add support for creating dynamic agent cards in the helloworld #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dmandar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the helloworld agent sample by introducing robust support for dynamic agent cards, allowing for more flexible and illustrative demonstrations of agent capabilities. It also streamlines the agent's configuration through a new command-line interface and includes a minor cleanup of project dependencies.
Highlights
- Dynamic Agent Card Support: Implemented the capability for the
helloworldagent to generate dynamic public and extended agent cards. This allows card properties like descriptions and skills to be updated at runtime, demonstrating more advanced agent features. - Command-Line Configuration: Introduced new command-line options (
--dynamic-public-card,--enable-extended-card,--dynamic-extended-card) using theclicklibrary. These options provide flexible control over the agent's card behavior, making the sample more configurable for different demonstration scenarios. - Agent Card Logic Refactoring: Refactored the agent card initialization and handling logic within
__main__.py. This includes moving the main execution into aclick-enabled function and conditionally applying card modifiers or static extended cards based on command-line arguments. - Updated Documentation: The
README.mdhas been updated with detailed instructions on how to run thehelloworldagent using the new command-line flags, including practical examples for enabling dynamic and extended card functionalities. - Dependency Cleanup: Removed an unused
dotenvdependency frompyproject.toml, addressing a minor build-related issue and streamlining the project's dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the helloworld agent sample by introducing support for dynamic public and extended agent cards, configurable via new command-line flags. The documentation is updated accordingly, and an unused dependency is removed.
The code changes are well-structured, using click for command-line parsing and dedicated functions for dynamic card generation. My review focuses on improving maintainability and robustness by addressing minor code duplication, adding validation for CLI flags, clarifying the use of a function parameter, and verifying the removal of a dependency. Overall, these are great additions that showcase more advanced features of the A2A protocol.
| skills=[skill], # Only the basic skill for the public card | ||
| supports_authenticated_extended_card=True, | ||
| ) | ||
| # --8<-- [end:AgentCard] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add these region tags back, they are used in the public tutorial https://a2a-protocol.org/latest/tutorials/python/3-agent-skills-and-card/#agent-skills
..sample. Also fix some build issues.