fix: correct the default value in the comment#130
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @hujiulong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor documentation inaccuracy by updating a comment that describes the default value for a configuration path. The change ensures that the documented default path accurately reflects its intended format, improving clarity for developers.
Highlights
- Documentation Correction: Corrected the default value for agentCardPath in the JSDoc comment for A2AExpressApp.setupRoutes, removing an erroneous leading slash from the path.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request corrects a documentation error in the setupRoutes method. The JSDoc for the agentCardPath parameter incorrectly showed the default value with a leading slash. The change removes the slash, aligning the documentation with the actual default value provided by the AGENT_CARD_PATH constant. This is a good fix that improves documentation accuracy.
🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2025-11-05) ### Bug Fixes * cancel/task now returns the expected 'cancelled' task status ([#158](#158)) ([3eec0bd](3eec0bd)) * correct the default value in the agentCardPath comment ([#130](#130)) ([3279c7b](3279c7b)) * enable follow up task issue on non blocking request ([#160](#160)) ([352dc05](352dc05)) * ensure push notifications order ([#141](#141)) ([22360e6](22360e6)) * ensure user messages are added to existing tasks ([#138](#138)) ([00fb916](00fb916)) * validate JSON-RPC params ([#155](#155)) ([5b39f4d](5b39f4d)) * validate JSON-RPC request id according to the spec ([#152](#152)) ([9558c36](9558c36)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
The default value of
agentCardPathdoes not have a preceding slash.a2a-js/src/constants.ts
Line 8 in c055b76
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.