Skip to content

Commit 9e9adce

Browse files
aamcommit-bot@chromium.org
authored andcommitted
[observatory] Include observatory main.dart.js.map with debug build.
Having this map file allows for the browser to report source line numbers in case of exception thrown by Observatory code. Change-Id: Ia47789b89b3a14ca6513143bf9d4cc9c4a8cc1fb Reviewed-on: https://dart-review.googlesource.com/68847 Reviewed-by: Zach Anderson <[email protected]> Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Alexander Aprelev <[email protected]>
1 parent 7eda513 commit 9e9adce

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

runtime/observatory/BUILD.gn

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ prebuilt_dart2js_action("build_observatory") {
1919
outputs = [
2020
output,
2121
]
22+
if (is_debug) {
23+
outputs += [ "$target_gen_dir/observatory/web/main.dart.js.map" ]
24+
}
2225

2326
version_string = exec_script("../../tools/make_version.py",
2427
[
@@ -60,7 +63,6 @@ observatory_ignore_patterns = [
6063
"*.concat.js",
6164
"*.dart",
6265
"*.log",
63-
"*.map",
6466
"*.precompiled.js",
6567
"*.scriptUrls",
6668
"*_buildLogs*",
@@ -78,6 +80,10 @@ observatory_ignore_patterns = [
7880
"webcomponents.*",
7981
]
8082

83+
if (!is_debug) {
84+
observatory_ignore_patterns += [ "*.map" ]
85+
}
86+
8187
# The ignore_patterns entry in the scopes accepted by copy_trees() is a
8288
# string of comma delimited patterns.
8389
observatory_ignore_string = "\$sdk"
@@ -157,8 +163,11 @@ copy("copy_main_dart_js") {
157163
sources = [
158164
"$target_gen_dir/observatory/web/main.dart.js",
159165
]
166+
if (is_debug) {
167+
sources += [ "$target_gen_dir/observatory/web/main.dart.js.map" ]
168+
}
160169
outputs = [
161-
"$target_out_dir/observatory/deployed/web/main.dart.js",
170+
"$target_out_dir/observatory/deployed/web/{{source_file_part}}",
162171
]
163172
}
164173

0 commit comments

Comments
 (0)