fix(config): allow unlimuted text for config values (#394)

* fix(config): allow unlimited text for config values #393

Author: enudler

.circleci/docker-build.sh

@@ -1,7 +1,7 @@
 #!/bin/sh -e
 
 if [ "$CIRCLE_BRANCH" != "master" ] ; then
-    TAG=predator-$CIRCLE_BRANCH
+    TAG=`echo predator-$CIRCLE_BRANCH | tr -d /`
     IMAGE=zooz/predator-builds:$TAG
 else
     IMAGE=zooz/predator:latest
@@ -10,4 +10,5 @@ fi
 echo "Building Docker image $IMAGE on branch: $CIRCLE_BRANCH"
 docker build -t $IMAGE .
 echo $DOCKERHUB_PASSWORD | docker login -u $DOCKERHUB_USERNAME --password-stdin
-docker push $IMAGE
+docker push $IMAGE
+

src/configManager/models/database/sequelize/sequelizeConnector.js

@@ -65,7 +65,7 @@ async function initSchemas() {
             primaryKey: true
         },
         value: {
-            type: Sequelize.DataTypes.STRING
+            type: Sequelize.DataTypes.TEXT
         }
     });
     await config.sync();

src/database/sequlize-handler/migrations/07_config_large.js

@@ -0,0 +1,15 @@
+const Sequelize = require('sequelize');
+
+module.exports.up = async (query, DataTypes) => {
+    let configTable = await query.describeTable('configs');
+
+    if (configTable.value) {
+        await query.changeColumn(
+            'configs', 'value', {
+                type: Sequelize.TEXT
+            });
+    }
+};
+
+module.exports.down = async (query, DataTypes) => {
+};

tests/integration-tests/configManager/configHandler-test.js

@@ -22,6 +22,7 @@ const defaultBody = {
         client_errors_ratio: { percentage: 20 },
         rps: { percentage: 20 }
     }
+
 };
 const updateBodyWithTypes = {
     influx_metrics: {
@@ -160,6 +161,45 @@ describe('update and get config', () => {
         });
     });
 
+    describe('Update config with large json for custom runner definition', () => {
+        it('params below minimum', async () => {
+            let response = await configRequestCreator.updateConfig({
+                custom_runner_definition: {
+                    spec: {
+                        template: {
+                            spec: {
+                                containers: [{
+                                    resources: {
+                                        limits: {
+                                            memory: '512Mi',
+                                            cpu: '1'
+                                        },
+                                        requests: {
+                                            memory: '192Mi',
+                                            cpu: '1'
+                                        }
+                                    }
+                                }],
+                                nodeSelector: {
+                                    lifecycle: 'C5nSpot'
+                                },
+                                tolerations: [
+                                    {
+                                        key: 'instances',
+                                        operator: 'Equal',
+                                        value: 'c5n',
+                                        effect: 'NoSchedule'
+                                    }
+                                ]
+                            }
+                        }
+                    }
+                }
+            });
+            should(response.statusCode).eql(200);
+        });
+    });
+
     describe('Update config validation', () => {
         it('update config fail with validation require fields', async () => {
             let response = await configRequestCreator.updateConfig(requestBodyNotValidRequire);
@@ -222,7 +262,7 @@ describe('update and get config', () => {
         it('update config fail with validation type', async () => {
             let response = await configRequestCreator.updateConfig({
                 benchmark_threshold: 20,
-                benchmark_weights: { 'tps': '10' }
+                benchmark_weights: { tps: '10' }
             });
             should(response.statusCode).eql(400);
             should(response.body.message).eql(validationError);