Skip to content

Commit ab3eaa6

Browse files
Zen-cronicZirak
authored andcommitted
refactor(examples/http): use new exported string constants for semconv (open-telemetry#4750)
* refactor(examples/http): use new exported string constants for semconv * added changelog entry * refactor(examples/http): actually use new exported string constants for semconv
1 parent 5339bc5 commit ab3eaa6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
2424

2525
### :books: (Refine Doc)
2626

27+
* refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic
28+
2729
### :house: (Internal)
2830

2931
## 1.24.1

examples/http/tracer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
55
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions');
88
const { SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base');
99
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
1010
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
@@ -15,7 +15,7 @@ const EXPORTER = process.env.EXPORTER || '';
1515
module.exports = (serviceName) => {
1616
const provider = new NodeTracerProvider({
1717
resource: new Resource({
18-
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
18+
[SEMRESATTRS_SERVICE_NAME]: serviceName,
1919
}),
2020
});
2121

0 commit comments

Comments
 (0)