Skip to content

Commit 9e818a5

Browse files
authored
chore: Updating the settings icon throughout the product (appsmithorg#37330)
## Description Updating the settings icon throughout the product to use the below icon: https://www.figma.com/design/8L9BXMzNTKboGWlHpdXyYP/Appsmith-IDE?node-id=33-3546&t=qpptzxhkWatrFIn1-4 Fixes [appsmithorg#37248](appsmithorg#37248) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11796204902> > Commit: 0e57343 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11796204902&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 12 Nov 2024 12:12:33 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated icons for various settings-related components from "settings-2-line" to "settings-v3" to enhance visual representation. - **Bug Fixes** - Improved handling of frame ancestor settings in the AdminSettings configuration, ensuring better management of stored values. - **Documentation** - No changes to the documentation were made in this release. - **Chores** - Updated multiple components to reflect the new icon, maintaining overall functionality without introducing new logic. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 3e55611 commit 9e818a5

13 files changed

Lines changed: 16 additions & 34 deletions

File tree

Lines changed: 3 additions & 21 deletions
Loading

packages/dsl/src/migrate/helpers/widget-configs.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7311,7 +7311,7 @@
73117311
"controlType": "OPEN_CONFIG_PANEL",
73127312
"buttonConfig": {
73137313
"label": "Configure",
7314-
"icon": "settings-2-line"
7314+
"icon": "settings-v3"
73157315
},
73167316
"label": "Configure menu items",
73177317
"isBindProperty": false,
@@ -47874,7 +47874,7 @@
4787447874
"controlType": "OPEN_CONFIG_PANEL",
4787547875
"buttonConfig": {
4787647876
"label": "Configure",
47877-
"icon": "settings-2-line"
47877+
"icon": "settings-v3"
4787847878
},
4787947879
"label": "Configure menu items",
4788047880
"isBindProperty": false,

src/IDE/Components/ToolbarSettingsPopover.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export const ToolbarSettingsPopover = (props: Props) => {
4545
<ToggleButton
4646
data-testid={props.dataTestId}
4747
disabled={props.disabled}
48-
icon="settings-2-line"
48+
icon="settings-v3"
4949
isSelected={isOpen}
5050
onClick={handleButtonClick}
5151
size="md"

src/ce/pages/AdminSettings/config/general.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ export const APPSMITH_ALLOWED_FRAME_ANCESTORS_SETTING: Setting = {
181181
};
182182

183183
export const config: AdminConfigType = {
184-
icon: "settings-2-line",
184+
icon: "settings-v3",
185185
type: SettingCategories.GENERAL,
186186
categoryType: CategoryType.GENERAL,
187187
controlType: SettingTypes.GROUP,

src/ce/pages/Applications/WorkspaceMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ function WorkspaceMenu({
144144
})
145145
}
146146
>
147-
<Icon name="settings-2-line" size="md" />
147+
<Icon name="settings-v3" size="md" />
148148
Settings
149149
</CustomMenuItem>
150150
</>

src/components/propertyControls/DraggableListCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ export function DraggableListCard(props: RenderComponentProps) {
205205
}}
206206
onFocus={(e) => e.stopPropagation()}
207207
size="sm"
208-
startIcon="settings-2-line"
208+
startIcon="settings-v3"
209209
/>
210210
)}
211211
{showDelete && (

src/modules/ui-builder/ui/wds/WDSMenuButtonWidget/config/propertyPaneConfig/contentConfig.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export const propertyPaneContentConfig = [
8888
controlType: "OPEN_CONFIG_PANEL",
8989
buttonConfig: {
9090
label: "Configure",
91-
icon: "settings-2-line",
91+
icon: "settings-v3",
9292
},
9393
label: "Configure menu items",
9494
isBindProperty: false,

src/pages/Editor/AppSettingsPane/AppSettings/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ function AppSettings() {
126126
const SectionHeadersConfig: SectionHeaderProps[] = [
127127
{
128128
id: "t--general-settings-header",
129-
icon: "settings-2-line",
129+
icon: "settings-v3",
130130
isSelected: selectedTab.type === AppSettingsTabs.General,
131131
name: createMessage(GENERAL_SETTINGS_SECTION_HEADER),
132132
onClick: () => {

src/pages/Editor/gitSync/QuickGitActions/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ const getQuickActionButtons = ({
215215
},
216216
{
217217
className: "t--bottom-git-settings",
218-
icon: "settings-2-line",
218+
icon: "settings-v3",
219219
onClick: settings,
220220
tooltipText: createMessage(GIT_SETTINGS),
221221
},

src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const allStaticChangeDefs: Record<
4949
[StaticChangeKind.SETTINGS]: (status: GitStatusData) => ({
5050
condition: status.modified.includes("application.json"),
5151
message: "Application settings modified",
52-
iconName: "settings-2-line",
52+
iconName: "settings-v3",
5353
}),
5454
[StaticChangeKind.THEME]: (status: GitStatusData) => ({
5555
condition: status.modified.includes("theme.json"),

0 commit comments

Comments
 (0)