refactor: unify result analysis pattern across PfcXoff and IngressDrop executors

PfcXoff used explicit all_true/all_false/all_equal pattern (8 lines).
IngressDrop used concise set-dedup pattern (3 lines). Both produce
identical outcomes for all input combinations.

Unified to the concise pattern with descriptive comment:
  return_result = (True, results[0])
  # Multiple attempts: check consistency (set dedup detects mixed True/False)
  if len(results) > 1 and len(set(results)) > 1:
      return_result = (False, False)

UT coverage: PR sonic-net#22545 (e2fca74) — 12 new tests covering all 6 input
combinations for both executors.

Addresses @StormLiangMS review: inconsistent result patterns.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Xu Chen <[email protected]>

Author: XuChen-MSFT

tests/saitests/probe/ingress_drop_probing_executor.py

@@ -272,8 +272,7 @@ def check(self, src_port: int, dst_port: int, value: int, attempts: int = 1,
 
             # ===== Result analysis based on attempts =====
             return_result = (True, results[0])
-            # Multiple attempts: check consistency
-            # Inconsistent results indicate noise/error
+            # Multiple attempts: check consistency (set dedup detects mixed True/False)
             if len(results) > 1 and len(set(results)) > 1:
                 return_result = (False, False)
 

tests/saitests/probe/pfc_xoff_probing_executor.py

@@ -176,31 +176,17 @@ def check(self, src_port: int, dst_port: int, value: int, attempts: int = 1,
                         f"pfc_triggered={pfc_triggered}")
 
             # Result analysis based on attempts
-            if attempts == 1:
-                # Single attempt: direct result
-                detected = results[0]
-                success = True
-            else:
-                # Multiple attempts: require consistent results for reliable detection
-                all_true = all(results)
-                all_false = not any(results)
-                all_equal = all_true or all_false
-
-                if all_equal:
-                    # Verification successful - consistent results
-                    detected = results[0]  # Any result since they're all the same
-                    success = True
-                else:
-                    # Verification failed - inconsistent results indicate noise/error
-                    detected = False
-                    success = False
+            return_result = (True, results[0])
+            # Multiple attempts: check consistency (set dedup detects mixed True/False)
+            if len(results) > 1 and len(set(results)) > 1:
+                return_result = (False, False)
 
             if self.verbose and self.observer:
                 self.observer.trace(
                     f"[PFC Xoff Executor] Check complete: value={value}, attempts={attempts}, "
-                    f"results={results}, final_detected={detected}, success={success}")
+                    f"results={results}, final_detected={return_result[1]}, success={return_result[0]}")
 
-            return success, detected
+            return return_result
 
         except Exception as e:
             if self.verbose and self.observer: