-
Notifications
You must be signed in to change notification settings - Fork 13
New compiler #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New compiler #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xircuits-compile input.xircuits output.py` will compile the given `input.xircuits` file into the given `output.py` file.
MFA-X-AI
approved these changes
Feb 20, 2023
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old compiler relied heavily on string concatenation to produce the output code.
This new compiler uses the python
astmodule to enforce syntactically correct code generation.Caveat: at the moment it does not care about the debug mode. We will rebuild the debug mode in a follow up PR.
Extra:
A Xircuits command has been added in this PR. Users can now compile .xircuits canvas from outside Jupyterlab using
xircuits-compile example_canvas.xircuits output.py.Pull Request Type
Type of Change
Tests
xircuits-compile example_canvas.xircuits output.py.Tested on?
TODO