different take on directive imports

Author: matthewnitschke-wk

lib/src/scip_visitor.dart

@@ -32,7 +32,7 @@ class ScipVisitor extends GeneralizingAstVisitor {
           _projectRoot,
           pubspec,
         ) {
-    final fileSymbol = _symbolGenerator.fileSymbolFor(_relativePath);
+    final fileSymbol = _symbolGenerator.fileSymbolForPath(_relativePath);
     occurrences.add(Occurrence(
       symbol: fileSymbol,
       range: [0, 0, 0],
@@ -60,6 +60,8 @@ class ScipVisitor extends GeneralizingAstVisitor {
       _visitNormalFormalParameter(node);
     } else if (node is SimpleIdentifier) {
       _visitSimpleIdentifier(node);
+    } else if (node is Directive) {
+      _visitDirective(node);
     }
 
     super.visitNode(node);
@@ -107,6 +109,39 @@ class ScipVisitor extends GeneralizingAstVisitor {
     }
   }
 
+  void _visitDirective(Directive node) {
+    final element = node.element;
+
+    StringLiteral uriLiteral;
+    if (node is UriBasedDirective) {
+      uriLiteral = node.uri;
+    } else if (node is PartOfDirective && node.uri != null) {
+      uriLiteral = node.uri!;
+    } else {
+      return;
+    }
+
+    // uri is a non-relative, package (or dart sdk) uri: 
+    // Eg: `package:<name>/<path>.dart`, `dart:<name>`
+
+    // Uri uri;
+    // if (element is LibraryImportElement) {
+    //   uri = (element.uri as DirectiveUriWithSource).source.uri;
+    // } else if (element is LibraryExportElement) {
+    //   uri = (element.uri as DirectiveUriWithSource).source.uri;
+    // } else if (element is PartElement) {
+    //   uri = (element.uri as DirectiveUriWithSource).source.uri;
+    // } else if (node is PartOfDirective && element is LibraryElement) {
+    //   uri = element.source.uri;
+    // } else {
+    //   return;
+    // }
+
+    _symbolGenerator.symbolFor(element!);
+
+    // _symbolGenerator.fileSymbolForUri(uri);
+  }
+
   /// Registers the provided [element] as a reference to an existing definition
   ///
   /// [node] refers to the ast node where the reference exists, [element]

lib/src/symbol.dart

@@ -56,7 +56,7 @@ class SymbolGenerator {
     ].join(' ');
   }
 
-  String fileSymbolFor(String path) {
+  String fileSymbolForPath(String path) {
     return [
       'scip-dart',
       'pub ${_pubspec.name} ${_pubspec.version}',
@@ -219,6 +219,33 @@ class SymbolGenerator {
       return '${_getDescriptor(encEle)}${element.name}.';
     }
 
+    if (
+      element is LibraryImportElement || 
+      element is LibraryExportElement || 
+      element is PartElement
+    ) {
+      DirectiveUriWithSource directiveUri;
+      if (element is LibraryImportElement) {
+        directiveUri = element.uri as DirectiveUriWithSource;
+      } else if (element is LibraryExportElement) {
+        directiveUri = element.uri as DirectiveUriWithSource;
+      } else if (element is PartElement) {
+        directiveUri = element.uri as DirectiveUriWithSource;
+      } else {
+        return null;
+      }
+
+      final config = _packageConfig.packageOf(Uri.file(sourcePath));
+      if (config == null) {
+        throw Exception('Could not find package for $sourcePath. Have you run pub get?');
+      }
+
+      return _escapeNamespacePath(
+        sourcePath.substring(config.root.toFilePath().length),
+      );
+    }
+
+
     display('\n'
         'Received unknown type (${element.runtimeType})\n'
         '\tname: ${element.name}\n'