Skip to content

Commit 91f6962

Browse files
committed
fixed failing NODE_MODULE_VERSION check
1 parent 7746b0d commit 91f6962

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

src/util/helpers.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,24 +86,12 @@ void SetPrototypeGetter(
8686
v8::AccessorNameGetterCallback func
8787
) {
8888
v8::HandleScope scope(isolate);
89-
90-
#if defined NODE_MODULE_VERSION && NODE_MODULE_VERSION < 121
91-
recv->InstanceTemplate()->SetAccessor(
92-
InternalizedFromLatin1(isolate, name),
93-
func,
94-
0,
95-
data,
96-
v8::AccessControl::DEFAULT,
97-
v8::PropertyAttribute::None
98-
);
99-
#else
10089
recv->InstanceTemplate()->SetNativeDataProperty(
10190
InternalizedFromLatin1(isolate, name),
10291
func,
10392
0,
10493
data
10594
);
106-
#endif
10795
}
10896

10997
#if defined(V8_ENABLE_SANDBOX)

src/util/macros.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
#define NODE_ARGUMENTS const v8::FunctionCallbackInfo<v8::Value>&
22
#define NODE_ARGUMENTS_POINTER const v8::FunctionCallbackInfo<v8::Value>*
33
#define NODE_METHOD(name) void name(NODE_ARGUMENTS info)
4-
#if defined NODE_MODULE_VERSION && NODE_MODULE_VERSION < 121
5-
#define NODE_GETTER(name) void name(v8::Local<v8::String> _, const v8::PropertyCallbackInfo<v8::Value>& info)
6-
#else
74
#define NODE_GETTER(name) void name(v8::Local<v8::Name> _, const v8::PropertyCallbackInfo<v8::Value>& info)
8-
#endif
95
#define INIT(name) v8::Local<v8::Function> name(v8::Isolate* isolate, v8::Local<v8::External> data)
106

117
#define EasyIsolate v8::Isolate* isolate = v8::Isolate::GetCurrent()

0 commit comments

Comments
 (0)