Skip to content

Commit f7c2364

Browse files
authored
Merge pull request #469 from WikipediaLibrary/kgraessle/T404381
Wikilink The Wall Street Journal collection not showing correct data
2 parents b949c5c + 3212d97 commit f7c2364

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

extlinks/links/management/commands/linkevents_collect.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ def _process_events(self, url):
8080
# A tuple value sets each respective value independently.
8181
# https://requests.readthedocs.io/en/latest/user/advanced/#timeouts
8282
timeout=(3.05, 7),
83+
headers={
84+
"User-Agent": 'Wikilink'
85+
}
8386
):
8487
if event.event == "message":
8588
try:
@@ -208,4 +211,5 @@ def _add_linkevent_to_db(self, link, change, event_data):
208211
)
209212
for url_pattern in url_patterns:
210213
url_pattern.link_events.add(link_event)
214+
url_pattern.collections.add(this_link_collection)
211215
url_pattern.save()

extlinks/links/tests.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,18 +291,21 @@ def test_management_command_non_proxy(self):
291291
with self.assertRaises(SystemExit):
292292
call_command("linkevents_collect", test=self.event_data1)
293293
self.assertEqual(LinkEvent.objects.count(), 1)
294+
self.assertEqual("JSTOR", URLPattern.objects.first().collections.first().name)
294295

295296
def test_management_command_proxy_urls(self):
296297
self.assertEqual(LinkEvent.objects.count(), 0)
297298
with self.assertRaises(SystemExit):
298299
call_command("linkevents_collect", test=self.event_data2)
299300
self.assertEqual(LinkEvent.objects.count(), 2)
301+
self.assertEqual("JSTOR", URLPattern.objects.first().collections.first().name)
300302

301303
def test_management_command_dates_with_micro_seconds(self):
302304
self.assertEqual(LinkEvent.objects.count(), 0)
303305
with self.assertRaises(SystemExit):
304306
call_command("linkevents_collect", test=self.event_data3)
305307
self.assertEqual(LinkEvent.objects.count(), 2)
308+
self.assertEqual("JSTOR", URLPattern.objects.first().collections.first().name)
306309

307310
class LinkEventsArchiveCommandTest(TransactionTestCase):
308311
def setUp(self):

0 commit comments

Comments
 (0)