fix: complete all 20 review thread fixes for PR #175

Author: Pip Build

web/src/components/ui/dialog.tsx

@@ -29,6 +29,7 @@ function DialogTrigger({ ...props }: React.ComponentProps<typeof DialogPrimitive
 /**
  * Renders a Dialog Portal element and forwards all received props to the underlying portal.
  *
+ * @param props - Props forwarded to Radix Dialog Portal primitive
  * @returns A React element representing the dialog portal.
  */
 function DialogPortal({ ...props }: React.ComponentProps<typeof DialogPrimitive.Portal>) {

web/src/components/ui/form.tsx

@@ -1,7 +1,7 @@
 'use client';
 
 import { Slot } from '@radix-ui/react-slot';
-import type { Label as LabelPrimitive } from 'radix-ui';
+import { Label as LabelPrimitive } from 'radix-ui';
 import * as React from 'react';
 import {
   Controller,
@@ -106,12 +106,21 @@ function FormLabel({ className, ...props }: React.ComponentProps<typeof LabelPri
 function FormControl({ ...props }: React.ComponentProps<typeof Slot>) {
   const { error, formItemId, formDescriptionId, formMessageId } = useFormField();
 
+  // Merge caller-provided aria-describedby with form field IDs
+  const callerDescribedBy = props['aria-describedby'];
+  const fieldDescribedBy = !error 
+    ? formDescriptionId 
+    : `${formDescriptionId} ${formMessageId}`;
+  const ariaDescribedBy = callerDescribedBy 
+    ? `${fieldDescribedBy} ${callerDescribedBy}` 
+    : fieldDescribedBy;
+
   return (
     <Slot
       {...props}
       data-slot="form-control"
       id={formItemId}
-      aria-describedby={!error ? `${formDescriptionId}` : `${formDescriptionId} ${formMessageId}`}
+      aria-describedby={ariaDescribedBy}
       aria-invalid={!!error}
     />
   );