DN-3426 feat: Add deadlines for steps #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goomens
reviewed
Nov 25, 2025
| { | ||
| EntityType = entityType, | ||
| ParentId = parentId, | ||
| CreatedOn = DateTime.UtcNow, |
Contributor
Author
There was a problem hiding this comment.
I see both are used currently; maybe make a team decission what to use? (Or maybe you have and i didn't know 😊 )
Member
There was a problem hiding this comment.
I don't think we have... let's discuss in the daily
| /// <summary> | ||
| /// Check if a deadline has passed | ||
| /// </summary> | ||
| public Date? Deadline { get; set; } |
Member
There was a problem hiding this comment.
Can't this replace Condition.Date entirely?
Contributor
Author
There was a problem hiding this comment.
I guess; though there is a small difference, currently the deadline condition is returned to the UI and the date is not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uvanose.atlassian.net/browse/DN-3426