feat: persist impact metrics accordion state in localStorage (#11477)

Author: FredrikOseberg

frontend/src/component/feature/FeatureView/FeatureImpactOverview/FeatureImpactHeader.tsx

@@ -1,4 +1,5 @@
-import { type FC, useState } from 'react';
+import type { FC } from 'react';
+import { useLocalStorageState } from 'hooks/useLocalStorageState';
 import { Button, Collapse, styled, Typography } from '@mui/material';
 import { Badge } from 'component/common/Badge/Badge';
 import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
@@ -109,14 +110,19 @@ export const FeatureImpactHeader: FC<FeatureImpactHeaderProps> = ({
     featureName,
     onAddChart,
 }) => {
-    const [expanded, setExpanded] = useState(false);
+    const [impactMetricsAccordionState, setImpactMetricsAccordionState] =
+        useLocalStorageState<'open' | 'closed'>(
+            'impact-metrics-accordion:expanded',
+            'closed',
+        );
     const { trackEvent } = usePlausibleTracker();
 
     const { impactMetrics } = useFeatureImpactMetrics({
         projectId,
         featureName,
     });
 
+    const expanded = impactMetricsAccordionState === 'open';
     const chartCount = impactMetrics.configs.length;
     const hasMetrics = chartCount > 0;
 
@@ -126,7 +132,7 @@ export const FeatureImpactHeader: FC<FeatureImpactHeaderProps> = ({
                 props: { eventType: 'impact-accordion-opened' },
             });
         }
-        setExpanded(!expanded);
+        setImpactMetricsAccordionState(expanded ? 'closed' : 'open');
     };
     const onHeaderKeyDown = (e: React.KeyboardEvent) => {
         if (e.key === 'Enter' || e.key === ' ') {

frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverview.tsx

@@ -89,7 +89,7 @@ export const FeatureOverview = ({ header }: FeatureOverviewProps) => {
                     ) : null}
                 </div>
                 <StyledMainContent>
-                    {header}
+                    {!loading && header}
                     <FeatureOverviewEnvironments
                         onToggleEnvOpen={toggleShowTooltip}
                         hiddenEnvironments={hiddenEnvironments}