require ToS for requesting PI group membership in groups.php (#353)

Co-authored-by: Copilot <[email protected]>

Author: simonLeary42

test/functional/PIMemberRequestTest.php

@@ -10,6 +10,7 @@ private function requestMembership(string $gid_or_mail)
         http_post(__DIR__ . "/../../webroot/panel/groups.php", [
             "form_type" => "addPIform",
             "pi" => $gid_or_mail,
+            "tos" => "agree",
         ]);
     }
 

test/functional/PiMemberApproveTest.php

@@ -34,6 +34,7 @@ private function requestJoinPI(string $gid)
         http_post(__DIR__ . "/../../webroot/panel/groups.php", [
             "form_type" => "addPIform",
             "pi" => $gid,
+            "tos" => "agree",
         ]);
     }
 

webroot/panel/groups.php

@@ -26,6 +26,9 @@
 
         switch ($_POST["form_type"]) {
             case "addPIform":
+                if (!isset($_POST["tos"]) || $_POST["tos"] != "agree") {
+                    UnityHTTPD::badRequest("user did not agree to terms of service");
+                }
                 if ($pi_account->exists()) {
                     if ($pi_account->requestExists($USER)) {
                         array_push($modalErrors, "You've already requested this");

webroot/panel/modal/new_pi.php

@@ -13,6 +13,13 @@
         <input type="text" id="pi_search" name="pi" placeholder="Search PI by NetID" required>
         <div class="searchWrapper" style="display: none;"></div>
     </div>
+    <label>
+        <input type='checkbox' name='tos' value='agree' required>
+        I have read and accept the
+        <a href='<?php echo CONFIG["site"]["terms_of_service_url"]; ?>' target='_blank'>
+            Terms of Service
+        </a>.
+    </label>
     <input type="submit" value="Send Request">
 </form>