Asset store release v0.2.0.27

Last minute additions:
- Added RecorderClip end call back

Author: jasonm-unity

source/FrameRecorder/Core/Editor/AboutBox.cs

@@ -66,7 +66,7 @@ public void OnGUI()
             GUILayout.BeginHorizontal();
             if (GUILayout.Button("Unity's User forum"))
             {
-                Application.OpenURL("https://forum.unity.com/categories/betas-experimental-features.86/");
+                Application.OpenURL("https://forum.unity.com/threads/unity-recorder-update.509458/");
                 this.Close();
             }
             GUILayout.EndHorizontal();

source/FrameRecorder/Core/Engine/RecorderVersion.cs

@@ -8,7 +8,7 @@ namespace UnityEditor.Recorder
     public class RecorderVersion : ScriptableObject
     {
         public const string Version = "0.2";  // major.minor.build
-        public static int BuildNumber = 25;
+        public static int BuildNumber = 27;
         public static string Tag
         {
             get { return string.Format("{0}.{1:0000}", Version, BuildNumber); }

source/FrameRecorder/Core/Engine/Timeline/RecorderClip.cs

@@ -13,6 +13,10 @@ namespace UnityEngine.Recorder.Timeline
     [System.ComponentModel.DisplayName("Recorder Clip")]
     public class RecorderClip : PlayableAsset, ITimelineClipAsset
     {
+        public delegate void RecordingClipDoneDelegate(RecorderClip clip);
+
+        public static RecordingClipDoneDelegate OnClipDone;
+
         [SerializeField]
         public RecorderSettings m_Settings;
 
@@ -28,7 +32,7 @@ public ClipCaps clipCaps
 
         public override Playable CreatePlayable(PlayableGraph graph, GameObject owner)
         {
-            var playable = ScriptPlayable<RecorderPlayableBehaviour>.Create( graph );
+            var playable = ScriptPlayable<RecorderPlayableBehaviour>.Create(graph);
             var behaviour = playable.GetBehaviour();
             if (recorderType != null && UnityHelpers.IsPlaying())
             {
@@ -37,6 +41,18 @@ public override Playable CreatePlayable(PlayableGraph graph, GameObject owner)
                     m_Recorder = RecordersInventory.GenerateNewRecorder(recorderType, m_Settings),
                     m_RecorderGO = SceneHook.HookupRecorder(),
                 };
+                behaviour.OnEnd = () =>
+                {
+                    try
+                    {
+                        if (OnClipDone != null) OnClipDone(this);     
+                    }
+                    catch (Exception ex)
+                    {
+                        Debug.Log("OnClipDone call back generated an exception: " + ex.Message );
+                        Debug.LogException(ex);
+                    }
+                };
             }
             return playable;
         }

source/FrameRecorder/Core/Engine/Timeline/RecorderPlayableBehaviour.cs

@@ -1,3 +1,4 @@
+using System;
 using UnityEngine.Playables;
 
 namespace UnityEngine.Recorder.Timeline
@@ -18,6 +19,8 @@ public class RecorderPlayableBehaviour : PlayableBehaviour
         WaitForEndOfFrameComponent endOfFrameComp;
         bool m_FirstOneSkipped;
 
+        public Action OnEnd;
+
         public override void OnGraphStart(Playable playable)
         {
             if (session != null)
@@ -30,8 +33,15 @@ public override void OnGraphStart(Playable playable)
 
         public override void OnGraphStop(Playable playable)
         {
-            if (session != null)
+            if (session != null && session.recording)
+            {
                 session.EndRecording();
+                session.Dispose();
+                session = null;
+
+                if (OnEnd != null)
+                    OnEnd();
+            }
         }
 
         public override void PrepareFrame(Playable playable, FrameData info)
@@ -74,6 +84,9 @@ public override void OnBehaviourPause(Playable playable, FrameData info)
                 session.EndRecording();
                 session.Dispose();
                 session = null;
+
+                if (OnEnd != null)
+                    OnEnd();
             }
 
             m_PlayState = PlayState.Paused;

source/FrameRecorder/Inputs/Camera360/Editor/Camera360InputEditor.cs

@@ -17,7 +17,8 @@ public class Camera360InputEditor : InputEditor
         SerializedProperty m_FlipFinalOutput;
         SerializedProperty m_StereoSeparation;
         SerializedProperty m_CubeMapSz;
-        SerializedProperty m_OutputSizePower;
+        SerializedProperty m_OutputWidth;
+        SerializedProperty m_OutputHeight;
         SerializedProperty m_RenderStereo;
 
         protected void OnEnable()
@@ -32,7 +33,8 @@ protected void OnEnable()
             m_StereoSeparation = pf.Find(w => w.m_StereoSeparation);
             m_FlipFinalOutput = pf.Find( w => w.m_FlipFinalOutput );
             m_CubeMapSz = pf.Find( w => w.m_MapSize );
-            m_OutputSizePower = pf.Find(w => w.m_OutputSizePower);
+            m_OutputWidth = pf.Find(w => w.m_OutputWidth);
+            m_OutputHeight = pf.Find(w => w.m_OutputHeight);
             m_RenderStereo = pf.Find(w => w.m_RenderStereo);
         }
 
@@ -60,14 +62,19 @@ public override void OnInspectorGUI()
                 --EditorGUI.indentLevel;
             }
 
-            AddProperty(m_OutputSizePower, () =>
+            AddProperty(m_OutputWidth, () =>
             {
-                AddProperty(m_OutputSizePower, () => EditorGUILayout.PropertyField(m_OutputSizePower, new GUIContent("Output size (power of 2)")));
+                AddProperty(m_OutputWidth, () => EditorGUILayout.PropertyField(m_OutputWidth, new GUIContent("Output width")));
+            });
+
+            AddProperty(m_OutputHeight, () =>
+            {
+                AddProperty(m_OutputWidth, () => EditorGUILayout.PropertyField(m_OutputHeight, new GUIContent("Output height")));
             });
 
             AddProperty(m_CubeMapSz, () =>
             {
-                AddProperty(m_CubeMapSz, () => EditorGUILayout.PropertyField(m_CubeMapSz, new GUIContent("Cube map size (power of 2)")));
+                AddProperty(m_CubeMapSz, () => EditorGUILayout.PropertyField(m_CubeMapSz, new GUIContent("Cube map width")));
             });
 
             AddProperty(m_RenderStereo, () =>

source/FrameRecorder/Inputs/Camera360/Engine/Camera360Input.cs

@@ -42,7 +42,8 @@ public override void BeginRecording(RecordingSession session)
         {
             if (settings360.m_FlipFinalOutput)
                 m_VFlipper = new TextureFlipper();
-            outputHeight = outputWidth = 1024;
+            outputWidth = settings360.m_OutputWidth;
+            outputHeight = settings360.m_OutputHeight;
         }
 
         public override void NewFrameStarting(RecordingSession session)
@@ -152,13 +153,15 @@ bool PrepFrameRenderTexture()
 
             outputRT = new RenderTexture(outputWidth, outputHeight, 24, RenderTextureFormat.ARGB32)
             {
-                dimension = TextureDimension.Cube
+                dimension = TextureDimension.Tex2D,
+                antiAliasing = 1
             };
-            m_Cubemap1 = new RenderTexture(256, 256, 24, RenderTextureFormat.ARGB32)
+            m_Cubemap1 = new RenderTexture(settings360.m_MapSize, settings360.m_MapSize, 24, RenderTextureFormat.ARGB32)
             {
-                dimension = TextureDimension.Cube 
+                dimension = TextureDimension.Cube ,
+                
             };
-            m_Cubemap2 = new RenderTexture(256, 256, 24, RenderTextureFormat.ARGB32)
+            m_Cubemap2 = new RenderTexture(settings360.m_MapSize, settings360.m_MapSize, 24, RenderTextureFormat.ARGB32)
             {
                 dimension = TextureDimension.Cube 
             };

source/FrameRecorder/Inputs/Camera360/Engine/Camera360InputSettings.cs

@@ -13,8 +13,9 @@ public class Camera360InputSettings : ImageInputSettings
         public bool m_FlipFinalOutput = false;
         public bool m_RenderStereo = true;
         public float m_StereoSeparation = 0.065f;
-        public int m_MapSize = 256;
-        public int m_OutputSizePower = 1024;
+        public int m_MapSize = 1024;
+        public int m_OutputWidth = 1024;
+        public int m_OutputHeight = 2048;
 
         public override Type inputType
         {
@@ -31,16 +32,28 @@ public override bool ValidityCheck( List<string> errors )
                 errors.Add("Missing camera tag");
             }
 
-            if (m_OutputSizePower != (1 << (int)Math.Log(m_OutputSizePower, 2)))
+            if (m_OutputWidth != (1 << (int)Math.Log(m_OutputWidth, 2)))
             {
                 ok =false;
-                errors.Add("Output size must be a power of 2.");
+                errors.Add("Output width must be a power of 2.");
             }
 
-            if (m_OutputSizePower < 128 || m_OutputSizePower > 8 * 1024)
+            if (m_OutputWidth < 128 || m_OutputWidth > 8 * 1024)
             {
                 ok = false;
-                errors.Add( string.Format( "Output size must fall between {0} and {1}.", 128, 8*1024 ));
+                errors.Add( string.Format( "Output width must fall between {0} and {1}.", 128, 8*1024 ));
+            }
+
+            if (m_OutputHeight != (1 << (int)Math.Log(m_OutputHeight, 2)))
+            {
+                ok =false;
+                errors.Add("Output height must be a power of 2.");
+            }
+
+            if (m_OutputHeight < 128 || m_OutputHeight > 8 * 1024)
+            {
+                ok = false;
+                errors.Add( string.Format( "Output height must fall between {0} and {1}.", 128, 8*1024 ));
             }
 
             if (m_MapSize != (1 << (int)Math.Log(m_MapSize, 2)))

source/FrameRecorder/Recorders/ImageRecorder/Engine/ImageRecorderSettings.cs

@@ -92,7 +92,7 @@ public override List<InputGroupFilter> GetInputGroups()
 #endif
                         new TInputFilter<CBRenderTextureInputSettings>("Camera(s)"),
 #if UNITY_2018_1_OR_NEWER
-                        new TInputFilter<Camera360InputSettings>("360 view"),
+                        new TInputFilter<Camera360InputSettings>("360 View (feature preview)"),
 #endif
                         new TInputFilter<RenderTextureSamplerSettings>("Sampling"),
                         new TInputFilter<RenderTextureInputSettings>("Render Texture"),