Issue 1234 boxfill anim broken #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add to let update know to use CellData rather than PointData code was in place but was returning False rather than True in this instance fix #1234 still need to add tests
add to let update know to use CellData rather than PointData code was in place but was returning False rather than True in this instance fix #1234 still need to add tests
Contributor
There was a problem hiding this comment.
These map entries really need some documentation. I have no idea what this change should do.
Contributor
Author
There was a problem hiding this comment.
yes but aren't we changing all of this anyway once we refactor?
Contributor
|
Building/testing now. |
Contributor
|
hey guys.. not picking on anyone but please use better short messages for the commit. |
Contributor
|
@dlonie I am assuming that you will have some feedback on it. |
Contributor
|
Yep, still building. Assuming all goes well this can go in -- we can work on documenting that map when the animation code gets hit by the refactoring sweep. |
Contributor
|
👍 in general we should document our code as much as possible atleast when something is not trivial or error prone. In my document, I will make it a requirement. |
Contributor
|
LGTM, tests pass. |
alliepiper
pushed a commit
that referenced
this pull request
Apr 28, 2015
Issue 1234 boxfill anim broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aashish24 @dlonie @chaosphere2112 goes with:
CDAT/uvcdat-testdata#37