fix #118 #1060
Merged
fix #118 #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@aashish24 @chaosphere2112 @durack1 @pletzer please review |
Member
|
@doutriaux1 does this work with the quirky non standard grids? |
Contributor
|
LGTM 👍 |
Contributor
Author
|
@durack1 nope because it falls back on regrid2 |
Member
|
@doutriaux1 will it bomb then if you try and use it? If so it might be useful to add a warning or error message, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using zonal grid as target switch to regrid2 for regrodTool as esmf seg faults