Include standard webpack start/end locations in emitted errors#1255
Merged
johnnyreilly merged 1 commit intoTypeStrong:masterfrom Feb 10, 2021
Merged
Include standard webpack start/end locations in emitted errors#1255johnnyreilly merged 1 commit intoTypeStrong:masterfrom
johnnyreilly merged 1 commit intoTypeStrong:masterfrom
Conversation
Member
|
This looks good - thanks for contributing! Could you update the |
bbbae2f to
348dddc
Compare
Contributor
Author
Done! |
Member
|
Keep getting a failing test.. rerunning |
Contributor
Author
|
@johnnyreilly yeash, I was thinking it was a known problem with the Travis setup. |
Member
|
Passing now - go figure |
Member
|
https://github.com/TypeStrong/ts-loader/releases/tag/v8.0.17 - released! Thanks for contributing 🌻❤️ |
This was referenced Mar 11, 2021
chore(deps): bump ts-loader from 6.2.2 to 8.0.18 in /OngekiScoreLog
project-primera/ongeki-score#357
Closed
This was referenced Mar 14, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
locproperty to all errors coming from TypeScript diagnostics.The property is the webpack "API" way of indicating the precise location of an error, including its end location.
In this way, the errors produced by
ts-loadercan be processed from the webpackStatsobject, with no knowledge ofts-loader.The previous location property is still available, so the change is backward-compatible.
Webpack will print its own error location string in the string output, in addition to the line and character that
ts-loaderalready includes in the error message. All comparison tests are updated to expect the new output.Closes #1199