Fix LLM streaming test race conditions after Vite update #7629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vite update changed async timing behavior, causing streaming tests to check WebSocket mocks before background operations completed. Tests expected
streamCalls.length > 5but got 0-1 due to the fire-and-forgethandleStreamingProcesspattern.Changes
Test synchronization
setTimeout(100)waits withvi.waitFor()polling for condition satisfactionMock setup improvements
mockChatStorage.getChat.mockResolvedValue(mockChat)to return new objects per call, preventing shared state mutations in concurrent scenariosmockChatStorage.updateChat.mockResolvedValue(undefined)to handle concurrent accessSyntax fixes
vi.mock()closures in 3 test files:;→)in mockImplementation functionsExample
Before:
After:
All 23 tests in
llm.spec.tsnow pass consistently.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn-images.mailchimp.com/usr/local/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/Trilium/Trilium/node_modules/vitest/suppress-warnings.cjs --experimental-vm-modules /home/REDACTED/work/Trilium/Trilium/node_modules/vitest/dist/workers/vmForks.js(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)mcusercontent.com/usr/local/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/Trilium/Trilium/node_modules/vitest/suppress-warnings.cjs --experimental-vm-modules /home/REDACTED/work/Trilium/Trilium/node_modules/vitest/dist/workers/vmForks.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.