This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Remove PropTypes check and warnings #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Works for me... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever you try and apply styles through html css - you're using propType functions directly which is throwing warnings that it will be removed in the next major version.
I understand why it's not feasible to use the standalone PropTypes package directly, as it isn't possible to infer the PropTypes functions from 'TextStylePropTypes' etc.
The original code would fail silently on invalid styles, I'm not entirely convinced that is the correct decision. So this basically removes the silent failure highlighting errors in styling, and removes the dependancy on PropTypes.
I've also bumped buffer to 5.0.0 - 4.9.1 was causing some errors with the Object.assign polyfill.