Fixing newly added test and serialization of std::system_error

- flyby: moved test to regression directory

Signed-off-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>

Author: hkaiser

libs/core/errors/include/hpx/errors/macros.hpp

@@ -18,11 +18,6 @@
 
 #include <type_traits>
 
-#if !defined(HPX_HAVE_CXX_MODULES) || defined(HPX_CORE_EXPORTS) ||             \
-    (defined(HPX_COMPILE_BMI) && defined(HPX_COMPILE_CORE_WITH_MODULES))
-#include <hpx/errors/throw_exception.hpp>
-#endif
-
 /// \cond NOINTERNAL
 ///////////////////////////////////////////////////////////////////////////////
 // helper macro allowing to prepend file name and line number to a generated

libs/core/serialization/src/exception_ptr.cpp

@@ -67,6 +67,12 @@ namespace hpx::serialization {
                     throw_line_ = *line;
                 }
             }
+            // NOLINTNEXTLINE(bugprone-empty-catch)
+            catch (...)
+            {
+                // plain exception_ptr (unrelated to HPX) was serialized, no
+                // special information is available
+            }
 
             // figure out concrete underlying exception type
             try
@@ -267,7 +273,7 @@ namespace hpx::serialization {
             case hpx::util::exception_type::std_system_error:
                 e = hpx::detail::get_exception(
                     std::system_error(static_cast<int>(err_value),
-                        std::system_category(), err_message),
+                        std::system_category(), what),
                     throw_function_, throw_file_, throw_line_);
                 break;
 

libs/core/serialization/tests/regressions/CMakeLists.txt

@@ -1,11 +1,13 @@
-# Copyright (c) 2019-2022 The STE||AR-Group
+# Copyright (c) 2019-2026 The STE||AR-Group
 #
 # SPDX-License-Identifier: BSL-1.0
 # Distributed under the Boost Software License, Version 1.0. (See accompanying
 # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 
-set(tests buffer_overrun_2839 non_default_constructible_5886
-          not_bitwise_shared_ptr_serialization serialization_unsigned_buffer
+set(tests
+    buffer_overrun_2839 non_default_constructible_5886
+    not_bitwise_shared_ptr_serialization serialization_exception_ptr
+    serialization_unsigned_buffer
 )
 
 foreach(test ${tests})

…sts/unit/serialization_exception_ptr.cpp …ressions/serialization_exception_ptr.cpplibs/core/serialization/tests/unit/serialization_exception_ptr.cpp renamed to libs/core/serialization/tests/regressions/serialization_exception_ptr.cpp libs/core/serialization/tests/unit/serialization_exception_ptr.cpp renamed to libs/core/serialization/tests/regressions/serialization_exception_ptr.cpp

@@ -21,11 +21,9 @@
 // the deserialized exception carries the original, ungarbled values.
 
 #include <hpx/config.hpp>
-#include <hpx/errors/throw_exception.hpp>
 #include <hpx/modules/errors.hpp>
 #include <hpx/modules/serialization.hpp>
 #include <hpx/modules/testing.hpp>
-#include <hpx/serialization/exception_ptr.hpp>
 
 #include <climits>
 #include <exception>

libs/core/serialization/tests/unit/CMakeLists.txt

@@ -29,7 +29,7 @@ set(tests
     serialization_std_variant
 )
 
-set(full_tests serialization_raw_pointer serialization_exception_ptr)
+set(full_tests serialization_raw_pointer)
 
 if(HPX_SERIALIZATION_WITH_BOOST_TYPES)
   set(tests ${tests} serialization_boost_variant)