fix: useLocalFonts - find all of same family #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
problem is, I do not know how libass works with this, I don't know if for other cases it will pick the first font that matches, and it will be incorrect, aka the inverse of whats happening here could happen? that would need to be investigated, if libass is smart about picking the correct weight, and you can show this, then i'll merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #55
This PR tries to illustrate the problem in #55. It might not be the "correct" solution to the problem (although it solves my immediate issue), so feel free to take over or discard it.
The proposed fix it to find local fonts by family name instead of name, then provide all found. I guess ideally we would like to find only e.g. Arial Bold, but then more information is needed about which font is wanted.