Fix review issues

Author: vbreuss

Source/Mockolate/Interactions/MockInteractions.cs

@@ -34,7 +34,7 @@ TInteraction IMockInteractions.RegisterInteraction<TInteraction>(TInteraction in
 	{
 		_missingVerification?.Add(interaction);
 		_interactions.TryAdd(interaction.Index, interaction);
-		InteractionAdded?.Invoke(this, interaction);
+		InteractionAdded?.Invoke(this, EventArgs.Empty);
 		return interaction;
 	}
 
@@ -47,11 +47,7 @@ public IReadOnlyCollection<IInteraction> GetUnverifiedInteractions()
 		return _missingVerification;
 	}
 
-	/// <summary>
-	///     Notifies whenever an interaction was registered on the mock.
-	/// </summary>
-	public event EventHandler<IInteraction>? InteractionAdded;
-
+	internal event EventHandler? InteractionAdded;
 	internal event EventHandler? OnClearing;
 
 	internal int GetNextIndex()

Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt

@@ -534,7 +534,6 @@ namespace Mockolate.Interactions
         public MockInteractions() { }
         public int Count { get; }
         public System.Collections.Generic.IEnumerable<Mockolate.Interactions.IInteraction> Interactions { get; }
-        public event System.EventHandler<Mockolate.Interactions.IInteraction>? InteractionAdded;
         public System.Collections.Generic.IReadOnlyCollection<Mockolate.Interactions.IInteraction> GetUnverifiedInteractions() { }
     }
     [System.Diagnostics.DebuggerDisplay("{ToString()}")]

Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt

@@ -533,7 +533,6 @@ namespace Mockolate.Interactions
         public MockInteractions() { }
         public int Count { get; }
         public System.Collections.Generic.IEnumerable<Mockolate.Interactions.IInteraction> Interactions { get; }
-        public event System.EventHandler<Mockolate.Interactions.IInteraction>? InteractionAdded;
         public System.Collections.Generic.IReadOnlyCollection<Mockolate.Interactions.IInteraction> GetUnverifiedInteractions() { }
     }
     [System.Diagnostics.DebuggerDisplay("{ToString()}")]

Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt

@@ -500,7 +500,6 @@ namespace Mockolate.Interactions
         public MockInteractions() { }
         public int Count { get; }
         public System.Collections.Generic.IEnumerable<Mockolate.Interactions.IInteraction> Interactions { get; }
-        public event System.EventHandler<Mockolate.Interactions.IInteraction>? InteractionAdded;
         public System.Collections.Generic.IReadOnlyCollection<Mockolate.Interactions.IInteraction> GetUnverifiedInteractions() { }
     }
     [System.Diagnostics.DebuggerDisplay("{ToString()}")]

…ts/Interactions/MockInteractionsTests.cs ….Internal.Tests/MockInteractionsTests.csTests/Mockolate.Tests/Interactions/MockInteractionsTests.cs renamed to Tests/Mockolate.Internal.Tests/MockInteractionsTests.cs Tests/Mockolate.Tests/Interactions/MockInteractionsTests.cs renamed to Tests/Mockolate.Internal.Tests/MockInteractionsTests.cs

@@ -1,14 +1,13 @@
-using System.Collections.Generic;
 using Mockolate.Interactions;
 
-namespace Mockolate.Tests.Interactions;
+namespace Mockolate.Internal.Tests;
 
 public class MockInteractionsTests
 {
 	[Fact]
 	public async Task InteractionAdded_ShouldIncludeInteraction()
 	{
-		List<IInteraction> addedInteractions = [];
+		int interactionCount = 0;
 		MockInteractions sut = new();
 		MethodInvocation interaction = new(0, "foo", []);
 		sut.InteractionAdded += OnInteractionAdded;
@@ -17,11 +16,11 @@ public async Task InteractionAdded_ShouldIncludeInteraction()
 
 		sut.InteractionAdded -= OnInteractionAdded;
 
-		await That(addedInteractions).HasSingle().Which.IsSameAs(interaction);
+		await That(interactionCount).IsEqualTo(1);
 
-		void OnInteractionAdded(object? sender, IInteraction e)
+		void OnInteractionAdded(object? sender, EventArgs e)
 		{
-			addedInteractions.Add(e);
+			interactionCount++;
 		}
 	}
 

Tests/Mockolate.Tests/Verify/MockVerifyTests.cs

@@ -276,7 +276,7 @@ public async Task VerificationResult_ShouldUpdateWhenInteractionsChange()
 
 		await That(r0).IsTrue().Because("No interaction was performed yet");
 		await That(r1).IsTrue().Because("One interaction was performed");
-		await That(r2).IsTrue().Because("The second interactions did not match");
-		await That(r3).IsTrue().Because("The third interactions did again match");
+		await That(r2).IsTrue().Because("The second interaction did not match");
+		await That(r3).IsTrue().Because("The third interaction did again match");
 	}
 }