remove null reference warnings and anything that turned on after enabling nullable

Author: asos-gurpreetsingh

src/Samples/TestStack.BDDfy.Samples/Atm/AccountHasInsufficientFund.cs

@@ -5,8 +5,8 @@ namespace TestStack.BDDfy.Samples.Atm
 {
     public class AccountHasInsufficientFund
     {
-        private Card _card;
-        private Atm _atm;
+        private Card _card = null!;
+        private Atm _atm = null!;
 
         // You can override step text using executable attributes
         [Given("Given the Account Balance is $10")]
@@ -63,5 +63,12 @@ public void VerifyLazy()
             var engine = this.LazyBDDfy<AccountHolderWithdrawsCash>();
             engine.Run();
         }
+
+        [Fact]
+        public void VerifyLazyWithAllArguments()
+        {
+            var engine = this.LazyBDDfy<AccountHolderWithdrawsCash>("lazy scenario", nameof(AccountHasInsufficientFund));
+            engine.Run();
+        }
     }
 }

src/Samples/TestStack.BDDfy.Samples/Atm/AccountHolderWithdrawsCash.cs

@@ -16,8 +16,8 @@ public class AccountHolderWithdrawsCash
         private const string WhenTheAccountHolderRequestsTitleTemplate = "When the account holder requests ${0}";
         private const string AndTheCardShouldBeReturnedTitleTemplate = "And the card should be returned";
 
-        private Card _card;
-        private Atm _atm;
+        private Card _card = null!;
+        private Atm _atm = null!;
 
         internal void Given_the_Account_Balance_is(int balance)
         {

src/Samples/TestStack.BDDfy.Samples/BuyingTrainFareWithExamples.cs

@@ -3,14 +3,12 @@
 
 namespace TestStack.BDDfy.Samples
 {
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "<Pending>")]
     public class BuyingTrainFareWithExamples
     {
-        #pragma warning disable 649
-        // ReSharper disable once InconsistentNaming
-        private readonly Fare fare;
-        private readonly BuyerCategory _buyerCategory;
-        #pragma warning restore 649
-        Money Price { get; set; }
+        private readonly Fare fare = null!;
+        private readonly BuyerCategory _buyerCategory = default!;
+        Money Price { get; set; } = null!;
 
         [Fact]
         public void SuccessfulRailCardPurchases()

src/Samples/TestStack.BDDfy.Samples/BuyingTrainFares/Money.cs

@@ -11,9 +11,9 @@ protected bool Equals(Money other)
             return Amount == other.Amount;
         }
 
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
-            if (ReferenceEquals(null, obj)) return false;
+            if (obj is null) return false;
             if (ReferenceEquals(this, obj)) return true;
             if (obj.GetType() != GetType()) return false;
             return Equals((Money)obj);

src/Samples/TestStack.BDDfy.Samples/CanRunAsyncVoidSteps.cs

@@ -7,7 +7,7 @@ namespace TestStack.BDDfy.Samples
 {
     public class CanRunAsyncVoidSteps
     {
-        private object _sut;
+        private object _sut = null!;
 
         internal async void GivenSomeAsyncSetup()
         {

src/Samples/TestStack.BDDfy.Samples/CustomTextReporter.cs

@@ -14,7 +14,7 @@ public class CustomTextReporter : IProcessor
     {
         private static readonly string Path;
 
-        private static string OutputDirectory
+        private static string? OutputDirectory
         {
             get
             {
@@ -25,7 +25,7 @@ private static string OutputDirectory
 
         static CustomTextReporter()
         {
-            Path = System.IO.Path.Combine(OutputDirectory, "BDDfy-text-report.txt");
+            Path = System.IO.Path.Combine(OutputDirectory ?? string.Empty, "BDDfy-text-report.txt");
 
             if(File.Exists(Path))
                 File.Delete(Path);
@@ -52,7 +52,7 @@ public void Process(Story story)
             if (scenario.Result != Result.Passed && scenario.Steps.Any(s => s.Exception != null))
             {
                 scenarioReport.Append(string.Format("    {0} : ", scenario.Result));
-                scenarioReport.AppendLine(scenario.Steps.First(s => s.Result == scenario.Result).Exception.Message);
+                scenarioReport.AppendLine(scenario.Steps.First(s => s.Result == scenario.Result).Exception?.Message);
             }
 
             scenarioReport.AppendLine();

src/Samples/TestStack.BDDfy.Samples/GlobalSuppressions.cs

@@ -0,0 +1,8 @@
+// This file is used by Code Analysis to maintain SuppressMessage
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "Test step methods cannot be static", Scope = "namespaceanddescendants", Target = "~N:TestStack.BDDfy.Samples")]

src/Samples/TestStack.BDDfy.Samples/TestStack.BDDfy.Samples.csproj

@@ -15,6 +15,8 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.6.0" />
+    <PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.7.0" />
+    <PackageReference Include="Microsoft.Testing.Platform" Version="2.2.3" />
     <PackageReference Include="shouldly" Version="4.3.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
       <PrivateAssets>all</PrivateAssets>

src/Samples/TestStack.BDDfy.Samples/TicTacToe/Game.cs

@@ -25,7 +25,7 @@ public Game(string[] firstRow, string[] secondRow, string[] thirdRow)
             _board[2] = (string[])thirdRow.Clone();
         }
 
-        public string Winner
+        public string? Winner
         {
             get 
             {
@@ -62,15 +62,11 @@ public void PlayAt(int row, int column)
             _board[row][column] = player;
         }
 
-        public override bool Equals(object obj)
-        {
-            var game = obj as Game;
-            return game != null && base.Equals(game);
-        }
+        public override bool Equals(object? obj) => obj is Game game && Equals(game);
 
         public bool Equals(Game other)
         {
-            if (ReferenceEquals(null, other)) return false;
+            if (other is null) return false;
             if (ReferenceEquals(this, other)) return true;
 
             for (int i = 0; i < 3; i++)

src/Samples/TestStack.BDDfy.Samples/TicTacToe/Helpers.cs

@@ -18,7 +18,7 @@ public class GameUnderTest
         protected const string O = Game.O;
         protected const string N = Game.N;
 
-        protected Game Game { get; set; }
+        protected Game Game { get; set; } = null!;
     }
 
     public abstract class NewGame : GameUnderTest