[lib] Attempt at fixing memory leak caused by double retain

mta452 · mta452 · commit 7a259ab0f561 · 2025-11-27T04:05:21.000+05:00
diff --git a/Source/AttributeManager.c b/Source/AttributeManager.c
@@ -105,7 +105,6 @@ static void StoreAttributeDictionaryInCache(AttributeDictionaryCacheRef cache,
     /* Only cache if this is the last reference */
     if (retainCount == 1) {
         AttributeDictionaryClear(dictionary);
-        AttributeDictionaryRetain(dictionary);
         ListAdd(&cache->_attributeDicts, &dictionary);
     }
 }
@@ -666,7 +665,6 @@ static void RemoveAttributeEntryRange(AttributeManagerRef manager,
         AttributeEntry *entry = ListGetRef(&manager->_entries, entryIndex);
 
         StoreAttributeDictionaryInCache(&manager->_cache, entry->attributes);
-        AttributeDictionaryRelease(entry->attributes);
     }
 
     ListRemoveRange(&manager->_entries, index, length);

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@ static void StoreAttributeDictionaryInCache(AttributeDictionaryCacheRef cache,`
`105`	`105`	`/* Only cache if this is the last reference */`
`106`	`106`	`if (retainCount == 1) {`
`107`	`107`	`AttributeDictionaryClear(dictionary);`
`108`		`- AttributeDictionaryRetain(dictionary);`
`109`	`108`	`ListAdd(&cache->_attributeDicts, &dictionary);`
`110`	`109`	`}`
`111`	`110`	`}`
`@@ -666,7 +665,6 @@ static void RemoveAttributeEntryRange(AttributeManagerRef manager,`
`666`	`665`	`AttributeEntry *entry = ListGetRef(&manager->_entries, entryIndex);`
`667`	`666`
`668`	`667`	`StoreAttributeDictionaryInCache(&manager->_cache, entry->attributes);`
`669`		`- AttributeDictionaryRelease(entry->attributes);`
`670`	`668`	`}`
`671`	`669`
`672`	`670`	`ListRemoveRange(&manager->_entries, index, length);`