Skip to content

[YouTube] Fix signature deobfuscation function name extraction #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged

[YouTube] Fix signature deobfuscation function name extraction #1290

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
235dd7c
[YouTube] add new signature regex
FineFindus Mar 31, 2025
d914e86
[YouTube] extract global variable for signature deobfuscation
FineFindus May 26, 2025
a847fdb
[YouTube] Allow lowercase global array names
FineFindus Jul 11, 2025
1915dc6
[YouTube] Allow both types of string quotes
FineFindus Jul 11, 2025
249f8f8
Updated mocks
litetex Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...or/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeSignatureUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ final class YoutubeSignatureUtils {

private static final Pattern[] FUNCTION_REGEXES = {
// CHECKSTYLE:OFF
Pattern.compile("\\b(?:[a-zA-Z0-9_$]+)&&\\((?:[a-zA-Z0-9_$]+)=([a-zA-Z0-9_$]{2,})\\(decodeURIComponent\\((?:[a-zA-Z0-9_$]+)\\)\\)"),
Pattern.compile("\\bm=([a-zA-Z0-9$]{2,})\\(decodeURIComponent\\(h\\.s\\)\\)"),
Pattern.compile("\\bc&&\\(c=([a-zA-Z0-9$]{2,})\\(decodeURIComponent\\(c\\)\\)"),
Pattern.compile("(?:\\b|[^a-zA-Z0-9$])([a-zA-Z0-9$]{2,})\\s*=\\s*function\\(\\s*a\\s*\\)\\s*\\{\\s*a\\s*=\\s*a\\.split\\(\\s*\"\"\\s*\\)"),
Expand All @@ -36,9 +37,12 @@ final class YoutubeSignatureUtils {
private static final String DEOBF_FUNC_REGEX_START = "(";
private static final String DEOBF_FUNC_REGEX_END = "=function\\([a-zA-Z0-9_]+\\)\\{.+?\\})";

private static final String SIG_DEOBF_HELPER_OBJ_NAME_REGEX = ";([A-Za-z0-9_\\$]{2,})\\...\\(";
// CHECKSTYLE:OFF
private static final String SIG_DEOBF_GLOBAL_ARRAY_REGEX = "(var [A-z]=['\"].*['\"].split\\(\";\"\\))";
private static final String SIG_DEOBF_HELPER_OBJ_NAME_REGEX = ";([A-Za-z0-9_\\$]{2,})\\[..";
private static final String SIG_DEOBF_HELPER_OBJ_REGEX_START = "(var ";
private static final String SIG_DEOBF_HELPER_OBJ_REGEX_END = "=\\{(?>.|\\n)+?\\}\\};)";
// CHECKSTYLE:ON

private YoutubeSignatureUtils() {
}
Expand Down Expand Up @@ -87,6 +91,9 @@ static String getDeobfuscationCode(@Nonnull final String javaScriptPlayerCode)
// Assert the extracted deobfuscation function is valid
JavaScript.compileOrThrow(deobfuscationFunction);

final String globalVar =
Parser.matchGroup1(SIG_DEOBF_GLOBAL_ARRAY_REGEX, javaScriptPlayerCode);

final String helperObjectName =
Parser.matchGroup1(SIG_DEOBF_HELPER_OBJ_NAME_REGEX, deobfuscationFunction);

Expand All @@ -97,7 +104,7 @@ static String getDeobfuscationCode(@Nonnull final String javaScriptPlayerCode)
+ deobfuscationFunctionName
+ "(a);}";

return helperObject + deobfuscationFunction + ";" + callerFunction;
return globalVar + ";" + helperObject + deobfuscationFunction + ";" + callerFunction;
} catch (final Exception e) {
throw new ParsingException("Could not parse deobfuscation function", e);
}
Expand Down