start making feature types be dynamic

Author: KevinVandy

docs/guide/custom-features.md

@@ -45,7 +45,7 @@ export interface TableFeature<TFeatures extends TableFeatures, TData extends Row
   _getDefaultColumnDef?: () => Partial<ColumnDef<TFeatures, TData, unknown>>
   _getDefaultOptions?: (
     table: Table<TFeatures, TData>
-  ) => Partial<TableOptionsResolved<TFeatures, TData>>
+  ) => Partial<TableOptions<TFeatures, TData>>
   _getInitialState?: (initialState?: InitialTableState) => Partial<TableState>
 }
 ```
@@ -146,7 +146,7 @@ declare module '@tanstack/react-table' { // or whatever framework adapter you ar
   //merge our new feature's state with the existing table state
   interface TableState extends DensityTableState {}
   //merge our new feature's options with the existing table options
-  interface TableOptionsResolved<TFeatures extends TableFeatures, TData extends RowData>
+  interface TableOptions<TFeatures extends TableFeatures, TData extends RowData>
     extends DensityOptions {}
   //merge our new feature's instance APIs with the existing table instance APIs
   interface Table<TFeatures extends TableFeatures, TData extends RowData> extends DensityInstance {}

examples/react/custom-features/src/main.tsx

@@ -52,10 +52,8 @@ declare module '@tanstack/react-table' {
   //merge our new feature's state with the existing table state
   interface TableState extends DensityTableState {}
   //merge our new feature's options with the existing table options
-  interface TableOptionsResolved<
-    TFeatures extends TableFeatures,
-    TData extends RowData,
-  > extends DensityOptions {}
+  interface TableOptions<TFeatures extends TableFeatures, TData extends RowData>
+    extends DensityOptions {}
   //merge our new feature's instance APIs with the existing table instance APIs
   interface Table<TFeatures extends TableFeatures, TData extends RowData>
     extends DensityInstance {}

packages/angular-table/src/index.ts

@@ -7,7 +7,6 @@ import type {
   Table,
   TableFeatures,
   TableOptions,
-  TableOptionsResolved,
   TableState,
 } from '@tanstack/table-core'
 
@@ -41,26 +40,24 @@ export function injectTable<
 
     // Compose table options using computed.
     // This is to allow `tableSignal` to listen and set table option
-    const updatedOptions = computed<TableOptionsResolved<TFeatures, TData>>(
-      () => {
-        // listen to table state changed
-        const tableState = state()
-        // listen to input options changed
-        const tableOptions = options()
-        return {
-          ...table.options,
-          ...resolvedOptions,
-          ...tableOptions,
-          state: { ...tableState, ...tableOptions.state },
-          onStateChange: (updater) => {
-            const value =
-              updater instanceof Function ? updater(tableState) : updater
-            state.set(value)
-            resolvedOptions.onStateChange(updater)
-          },
-        }
-      },
-    )
+    const updatedOptions = computed<TableOptions<TFeatures, TData>>(() => {
+      // listen to table state changed
+      const tableState = state()
+      // listen to input options changed
+      const tableOptions = options()
+      return {
+        ...table.options,
+        ...resolvedOptions,
+        ...tableOptions,
+        state: { ...tableState, ...tableOptions.state },
+        onStateChange: (updater) => {
+          const value =
+            updater instanceof Function ? updater(tableState) : updater
+          state.set(value)
+          resolvedOptions.onStateChange(updater)
+        },
+      }
+    })
 
     // convert table instance to signal for proxify to listen to any table state and options changes
     const tableSignal = computed(

packages/lit-table/src/index.ts

@@ -4,7 +4,6 @@ import type {
   Table,
   TableFeatures,
   TableOptions,
-  TableOptionsResolved,
   TableState,
 } from '@tanstack/table-core'
 import type {
@@ -45,7 +44,7 @@ export class TableController<
 
   public table(options: TableOptions<TFeatures, TData>) {
     if (!this.tableInstance) {
-      const resolvedOptions: TableOptionsResolved<TFeatures, TData> = {
+      const resolvedOptions: TableOptions<TFeatures, TData> = {
         state: {},
         onStateChange: () => {}, // noop
         renderFallbackValue: null,

packages/qwik-table/src/index.tsx

@@ -5,7 +5,6 @@ import type {
   Table,
   TableFeatures,
   TableOptions,
-  TableOptionsResolved,
 } from '@tanstack/table-core'
 
 export * from '@tanstack/table-core'
@@ -36,7 +35,7 @@ export function useTable<
   TData extends RowData,
 >(options: TableOptions<TFeatures, TData>) {
   // Compose in the generic options to the user options
-  const resolvedOptions: TableOptionsResolved<TFeatures, TData> = {
+  const resolvedOptions: TableOptions<TFeatures, TData> = {
     state: {},
     onStateChange: () => {},
     renderFallbackValue: null,

packages/react-table/src/tableFactory.ts

@@ -1,4 +1,4 @@
-import { _createTable, createColumnHelper } from '@tanstack/table-core'
+import { createColumnHelper } from '@tanstack/table-core'
 import { useTable } from './useTable'
 import type {
   ColumnHelper,

packages/react-table/src/useTable.ts

@@ -10,12 +10,11 @@ import type {
   Table,
   TableFeatures,
   TableOptions,
-  TableOptionsResolved,
   TableState,
 } from '@tanstack/table-core'
 
 function useTableRef<TFeatures extends TableFeatures, TData extends RowData>(
-  options: TableOptionsResolved<TFeatures, TData>,
+  options: TableOptions<TFeatures, TData>,
 ): Table<TFeatures, TData> {
   const tableRef = React.useRef<Table<TFeatures, TData>>()
 
@@ -38,7 +37,7 @@ export function useTable<
     getInitialTableState(builtInFeatures, tableOptions.initialState),
   )
 
-  const statefulOptions: TableOptionsResolved<TFeatures, TData> = {
+  const statefulOptions: TableOptions<TFeatures, TData> = {
     ...tableOptions,
     state: { ...state, ...tableOptions.state },
     onStateChange: (updater) => {

packages/solid-table/src/index.tsx

@@ -1,12 +1,7 @@
 import { _createTable } from '@tanstack/table-core'
 import { createComponent, createComputed, mergeProps } from 'solid-js'
 import { createStore } from 'solid-js/store'
-import type {
-  RowData,
-  TableFeatures,
-  TableOptions,
-  TableOptionsResolved,
-} from '@tanstack/table-core'
+import type { RowData, TableFeatures, TableOptions } from '@tanstack/table-core'
 
 import type { JSX } from 'solid-js'
 
@@ -29,7 +24,7 @@ export function createTable<
   TFeatures extends TableFeatures,
   TData extends RowData,
 >(options: TableOptions<TFeatures, TData>) {
-  const resolvedOptions: TableOptionsResolved<TFeatures, TData> = mergeProps(
+  const resolvedOptions: TableOptions<TFeatures, TData> = mergeProps(
     {
       state: {}, // Dummy state
       onStateChange: () => {}, // noop

packages/svelte-table/src/table.svelte.ts

@@ -2,7 +2,7 @@ import {
   type RowData,
   type TableFeatures,
   type TableOptions,
-  type TableOptionsResolved,
+  type TableOptions,
   type TableState,
   _createTable,
 } from '@tanstack/table-core'
@@ -37,7 +37,7 @@ export function createTable<
   TFeatures extends TableFeatures,
   TData extends RowData,
 >(options: TableOptions<TFeatures, TData>) {
-  const resolvedOptions: TableOptionsResolved<TFeatures, TData> = mergeObjects(
+  const resolvedOptions: TableOptions<TFeatures, TData> = mergeObjects(
     {
       state: {},
       onStateChange() {},

packages/table-core/src/core/columns/Columns.types.ts

@@ -3,6 +3,7 @@ import type {
   CellData,
   Column,
   ColumnDef,
+  ColumnDef_All,
   RowData,
   TableFeatures,
 } from '../../types'
@@ -23,7 +24,7 @@ export interface Column_CoreProperties<
    * @link [API Docs](https://tanstack.com/table/v8/docs/api/core/column#columndef)
    * @link [Guide](https://tanstack.com/table/v8/docs/guide/column-defs)
    */
-  columnDef: ColumnDef<TFeatures, TData, TValue>
+  columnDef: ColumnDef_All<TData, TValue>
   /**
    * The child column (if the column is a group column). Will be an empty array if the column is not a group column.
    * @link [API Docs](https://tanstack.com/table/v8/docs/api/core/column#columns)