chore: add eslint configs and code pass

Author: KevinVandy

eslint.config.js

@@ -0,0 +1,17 @@
+// @ts-check
+
+// @ts-ignore Needed due to moduleResolution Node vs Bundler
+import { tanstackConfig } from '@tanstack/config/eslint'
+
+export default [
+  ...tanstackConfig,
+  {
+    name: 'tanstack/temp',
+    rules: {
+      'ts/ban-types': 'off',
+      'ts/no-empty-function': 'off',
+      'no-case-declarations': 'off',
+      'ts/naming-convention': 'off',
+    },
+  },
+]

package.json

@@ -9,9 +9,10 @@
     "clean": "pnpm --filter \"./packages/**\" run clean",
     "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...'); process.exit(1)}\" || npx -y only-allow pnpm",
     "test": "pnpm run test:ci",
-    "test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,test:build,build",
-    "test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:lib,test:types,test:build,build",
+    "test:pr": "nx affected --targets=test:format,test:eslint,test:sherif,test:knip,test:lib,test:types,test:build,build",
+    "test:ci": "nx run-many --targets=test:format,test:eslint,test:sherif,test:knip,test:lib,test:types,test:build,build",
     "test:format": "pnpm run prettier --check",
+    "test:eslint": "nx affected --target=test:eslint --exclude=examples/**",
     "test:sherif": "sherif",
     "test:lib": "nx affected --targets=test:lib --exclude=examples/**",
     "test:lib:dev": "pnpm test:lib && nx watch --all -- pnpm test:lib",
@@ -52,6 +53,7 @@
     "@testing-library/react": "^16.0.0",
     "@testing-library/react-hooks": "^8.0.1",
     "@types/node": "^20.14.9",
+    "eslint": "^9.6.0",
     "jsdom": "^24.1.0",
     "knip": "^5.23.2",
     "nx": "^19.3.2",

packages/angular-table/eslint.config.js

@@ -0,0 +1,10 @@
+// @ts-check
+
+import rootConfig from '../../eslint.config.js'
+
+export default [
+  ...rootConfig,
+  {
+    rules: {},
+  },
+]

packages/angular-table/package.json

@@ -46,6 +46,7 @@
     "build:types": "tsc --emitDeclarationOnly",
     "clean": "rimraf ./build && rimraf ./dist",
     "test:build": "publint --strict",
+    "test:eslint": "eslint ./src",
     "test:lib": "vitest",
     "test:lib:dev": "vitest --watch",
     "test:types": "tsc"

packages/angular-table/src/flex-render.ts

@@ -4,16 +4,16 @@ import {
   Directive,
   EmbeddedViewRef,
   Inject,
-  inject,
   InjectionToken,
   Injector,
   Input,
-  isSignal,
   type OnChanges,
   type SimpleChanges,
   TemplateRef,
   Type,
   ViewContainerRef,
+  inject,
+  isSignal,
 } from '@angular/core'
 
 export type FlexRenderContent<TProps extends NonNullable<unknown>> =
@@ -119,7 +119,7 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
     const getContext = () => this.props
 
     const proxy = new Proxy(this.props, {
-      get: (_, key) => getContext()?.[key as keyof typeof _],
+      get: (_, key) => getContext()[key as keyof typeof _],
     })
 
     const componentInjector = Injector.create({
@@ -148,7 +148,7 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
       // Only signal based input can be added here
       if (
         componentRef.instance?.hasOwnProperty(prop) &&
-        // @ts-ignore
+        // @ts-ignore - unknown error
         isSignal(componentRef.instance[prop])
       ) {
         componentRef.setInput(prop, this.props[prop])

packages/angular-table/src/index.ts

@@ -1,14 +1,14 @@
-import { computed, type Signal, signal } from '@angular/core'
-import {
+import { type Signal, computed, signal } from '@angular/core'
+import { _createTable } from '@tanstack/table-core'
+import { lazyInit } from './lazy-signal-initializer'
+import { proxifyTable } from './proxy'
+import type {
   RowData,
+  Table,
   TableOptions,
   TableOptionsResolved,
   TableState,
-  _createTable,
-  type Table,
 } from '@tanstack/table-core'
-import { lazyInit } from './lazy-signal-initializer'
-import { proxifyTable } from './proxy'
 
 export * from '@tanstack/table-core'
 
@@ -51,7 +51,7 @@ export function injectTable<TData extends RowData>(
           const value =
             updater instanceof Function ? updater(tableState) : updater
           state.set(value)
-          resolvedOptions.onStateChange?.(updater)
+          resolvedOptions.onStateChange(updater)
         },
       }
     })

packages/angular-table/src/lazy-signal-initializer.ts

@@ -18,7 +18,7 @@ export function lazyInit<T extends object>(initializer: () => T): T {
   const table = () => {}
 
   return new Proxy<T>(table as T, {
-    apply(target: T, thisArg: any, argArray: any[]): any {
+    apply(target: T, thisArg: any, argArray: Array<any>): any {
       initializeObject()
       if (typeof object === 'function') {
         return Reflect.apply(object, thisArg, argArray)

packages/angular-table/src/proxy.ts

@@ -1,4 +1,4 @@
-import { computed, type Signal, untracked } from '@angular/core'
+import { type Signal, computed, untracked } from '@angular/core'
 import { type Table } from '@tanstack/table-core'
 
 type TableSignal<T> = Table<T> & Signal<Table<T>>
@@ -76,7 +76,7 @@ function toComputed<T>(signal: Signal<Table<T>>, fn: Function) {
 
   const computedCache: Record<string, Signal<unknown>> = {}
 
-  return (...argsArray: any[]) => {
+  return (...argsArray: Array<any>) => {
     const serializedArgs = serializeArgs(...argsArray)
     if (computedCache.hasOwnProperty(serializedArgs)) {
       return computedCache[serializedArgs]?.()
@@ -92,6 +92,6 @@ function toComputed<T>(signal: Signal<Table<T>>, fn: Function) {
   }
 }
 
-function serializeArgs(...args: any[]) {
+function serializeArgs(...args: Array<any>) {
   return JSON.stringify(args)
 }

packages/angular-table/tsconfig.json

@@ -12,5 +12,5 @@
     "experimentalDecorators": true,
     "importHelpers": true
   },
-  "include": ["src", "tests", "vite.config.ts"]
+  "include": ["src", "tests", "eslint.config.js", "vite.config.ts"]
 }

packages/lit-table/eslint.config.js

@@ -0,0 +1,10 @@
+// @ts-check
+
+import rootConfig from '../../eslint.config.js'
+
+export default [
+  ...rootConfig,
+  {
+    rules: {},
+  },
+]