-
-
Notifications
You must be signed in to change notification settings - Fork 431
feat: add hidden tags #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add hidden tags #1139
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
35457ab
Add `is_hidden` field to the `tags` table
TrigamDev cda8594
Add hidden checkbox to the edit tag panel
TrigamDev e7e0130
Fix formatting
TrigamDev 172e083
Exclude hidden tags from search results
TrigamDev 440205c
Fix formatting (I should probably actually check before committing? l…
TrigamDev 7909e9b
Bit of cleanup
TrigamDev ef9825e
Add toggle for excluding hidden entries below search bar
TrigamDev 608dce1
That might be important maybe
TrigamDev d4d2371
Update Save Format Changes page in docs (and include updated test dat…
TrigamDev 91c9049
Simplify query and invert name+logic
TrigamDev f382199
Merge branch 'main' into pull/1139
CyanVoxel 7baf36e
chore: remove unused code, tweak strings
CyanVoxel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be necessary to grab each hidden tag ID to compare against for each query, instead the query should be able to be amended with something like a
WHEREexpression that checks if it has any tags with theis_hiddenproperty directly. The following should work:The
.any()method should returnTRUEif any of theEntry.tagshave.is_hidden, and the~will negate the whole expression so it evaluates toFALSEif theis_hiddenproperty is present andTRUEotherwise.