Skip to content

Conversation

@mono424
Copy link
Collaborator

@mono424 mono424 commented Sep 21, 2023

Motivation and Context

No possibility to change date and time of a lecture.

Description

  • Added Timing Fields to Lectures
  • Added Logs to changeSet
  • Added Computed Properties

Steps for Testing

Prerequisites:

  • 1 Lecturer
  1. Log in
  2. Navigate to a Course Management Page
  3. Change Date Time of a Lecture
  4. Reload Page
  5. Check if Time Date is still changed
  6. Check if other settings can be changed too.

Screenshots

Bildschirmaufnahme.2023-09-28.um.00.20.11.mov

Bildschirmfoto 2023-09-27 um 22 03 55

@mono424 mono424 marked this pull request as ready for review September 27, 2023 22:23
@joschahenningsen
Copy link
Member

@mono424 thanks! Do you have time to resolve the conflicts?

@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Sure currently not at a computer but will do today!

@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :)

1 similar comment
@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :)

@mono424
Copy link
Collaborator Author

mono424 commented Oct 18, 2023

@joschahenningsen Any update on this ? :)

@alexanderstephan alexanderstephan self-requested a review January 17, 2024 14:14
@SebiWrn SebiWrn mentioned this pull request Oct 21, 2024
@SebiWrn SebiWrn enabled auto-merge (squash) October 21, 2024 13:12
@SebiWrn SebiWrn disabled auto-merge October 21, 2024 13:13
@alexanderstephan alexanderstephan self-assigned this Oct 30, 2024
@SebiWrn SebiWrn requested a review from a team November 29, 2024 08:58
onUpdate: (data, dirtyState) => {
this.lectureData = data;
this.isDirty = dirtyState.isDirty;
this.isInvalid = data.duration <= 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably also check whether the requested time is at least 15 min from .Now() as stated in #1368, if it is an upcoming lecture.

mono424 and others added 2 commits January 26, 2025 00:31
@SebiWrn SebiWrn requested a review from karjo24 February 26, 2025 14:35
@carlobortolan carlobortolan linked an issue Oct 17, 2025 that may be closed by this pull request
@joschahenningsen
Copy link
Member

@carlobortolan what's the status on this? :)

@carlobortolan
Copy link
Member

@carlobortolan what's the status on this? :)

@joschahenningsen The lecture start/end change works fine, but I'm still working on handling some edge cases 😅, e.g.:

  • Changing the lecture start/end and lecture hall of a live lecture should not be possible (right?)
  • Changing the lecture start/end of a past lecture to a future date should probably also not be allowed, as it will otherwise be seen as an upcoming lecture by gocast and get overwritten

btw, are there any time restrictions with the runner-job-scheduling? i.e., do the runners fetch the upcoming lectures automatically (or do we need to update the runner job-schedule in some way when changing the lecture time)?

@joschahenningsen
Copy link
Member

  • Changing the lecture start/end and lecture hall of a live lecture should not be possible (right?)
  • Changing the lecture start/end of a past lecture to a future date should probably also not be allowed, as it will otherwise be seen as an upcoming lecture by gocast and get overwritten

Both sound reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make start and end time of a lecture editable

6 participants