-
Notifications
You must be signed in to change notification settings - Fork 54
Feature/add lecture time change #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
@mono424 thanks! Do you have time to resolve the conflicts? |
Sure currently not at a computer but will do today! |
Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :) |
1 similar comment
Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :) |
|
@joschahenningsen Any update on this ? :) |
| onUpdate: (data, dirtyState) => { | ||
| this.lectureData = data; | ||
| this.isDirty = dirtyState.isDirty; | ||
| this.isInvalid = data.duration <= 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably also check whether the requested time is at least 15 min from .Now() as stated in #1368, if it is an upcoming lecture.
Co-authored-by: kajo24 <[email protected]>
Co-authored-by: kajo24 <[email protected]>
|
@carlobortolan what's the status on this? :) |
@joschahenningsen The lecture start/end change works fine, but I'm still working on handling some edge cases 😅, e.g.:
btw, are there any time restrictions with the runner-job-scheduling? i.e., do the runners fetch the upcoming lectures automatically (or do we need to update the runner job-schedule in some way when changing the lecture time)? |
Both sound reasonable |
Motivation and Context
No possibility to change date and time of a lecture.
Description
Steps for Testing
Prerequisites:
Screenshots
Bildschirmaufnahme.2023-09-28.um.00.20.11.mov