Repository navigation
Commit 6a45d59
fix(ci): the reusable lanes land a module's static web assets, not only its DLLs
`node-repo-gate.yml` and `node-repo-publish-bake.yml` composed every external module
into `/ext/<Name>/` with `cp -R meshweaver/modules/.` and nothing else. A module bundle
carries its static web assets separately, under `meshweaver/moduleassets/`
(`NuGetPackageWriter.ModuleAssetFolder`), keeping their MODULE-RELATIVE path — which is
exactly the shape `ModuleLandingService` writes beside the entry assembly and
`MeshModuleStaticAssetExtensions` serves at `_content/<Name>/…`. So a module landed this
way LOADED PERFECTLY and then 404'd every asset it ships, announced in one LogDebug line.
Both lanes now copy `meshweaver/moduleassets/.` into the same module directory —
module-relative, not `wwwroot`-specific, so a second asset root would ride too — and
assert PER FILE that what the bundle ships is what the directory holds, failing closed
with both numbers. Each run prints its denominator (`N composed, M carrying static web
assets, K asset file(s) landed`), because an uncounted zero was what let this ride: 24 of
30 real modules legitimately ship none.
`.github/scripts/test-module-asset-landing.py` EXECUTES the fix rather than asserting
about it. It extracts BOTH lanes' step by `id:` (a copy would pass while the real thing
rots), reads the verdict off the landed bytes' sha256, reads the bundle layout out of
`NuGetPackageWriter` in src/ so a rename reds the harness, and carries two falsification
arms per lane that MUTATE the real step: the pre-fix body must fail the positive case,
and removing only the `cp` must trip the lane's own fail-closed check.
Measured against the 30 real module bundles of MeshWeaver.Plugins run 34086016940:
6 carry assets, 294 asset files shipped, 294 landed byte-identical with the fix — and
0 of 294 landed pre-fix, at exit code 0.
Closes #3514.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent b75f501 commit 6a45d59
7 files changed
Lines changed: 756 additions & 3 deletions
File tree
- .github
- scripts
- workflows
- src/MeshWeaver.Documentation/Data
- Architecture
- WhatsNew
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2103 | 2103 | | |
2104 | 2104 | | |
2105 | 2105 | | |
| 2106 | + | |
| 2107 | + | |
| 2108 | + | |
| 2109 | + | |
| 2110 | + | |
| 2111 | + | |
| 2112 | + | |
| 2113 | + | |
| 2114 | + | |
| 2115 | + | |
| 2116 | + | |
2106 | 2117 | | |
2107 | 2118 | | |
2108 | 2119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
843 | 843 | | |
844 | 844 | | |
845 | 845 | | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
846 | 849 | | |
| 850 | + | |
847 | 851 | | |
848 | 852 | | |
849 | 853 | | |
| |||
894 | 898 | | |
895 | 899 | | |
896 | 900 | | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
897 | 904 | | |
898 | 905 | | |
899 | 906 | | |
| |||
907 | 914 | | |
908 | 915 | | |
909 | 916 | | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
910 | 945 | | |
911 | | - | |
| 946 | + | |
912 | 947 | | |
913 | 948 | | |
| 949 | + | |
914 | 950 | | |
915 | 951 | | |
916 | 952 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
899 | 899 | | |
900 | 900 | | |
901 | 901 | | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
902 | 905 | | |
| 906 | + | |
903 | 907 | | |
904 | 908 | | |
905 | 909 | | |
| |||
934 | 938 | | |
935 | 939 | | |
936 | 940 | | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
937 | 944 | | |
938 | 945 | | |
939 | 946 | | |
| |||
947 | 954 | | |
948 | 955 | | |
949 | 956 | | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
950 | 985 | | |
951 | | - | |
| 986 | + | |
952 | 987 | | |
953 | 988 | | |
954 | 989 | | |
| |||
967 | 1002 | | |
968 | 1003 | | |
969 | 1004 | | |
| 1005 | + | |
970 | 1006 | | |
971 | 1007 | | |
972 | 1008 | | |
| |||
0 commit comments