-
Notifications
You must be signed in to change notification settings - Fork 346
Added Windows support for NVIDIA, AMD, and Intel GPUs, and faster startup time #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
admercs
wants to merge
17
commits into
Syllo:master
Choose a base branch
from
nervosys:windows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement Windows-specific NVIDIA GPU detection using NVML dynamic loading - Add extract_gpuinfo_nvidia_windows.c with full vendor registration - Create Windows compatibility layer (windows_compat.c/h) - Add Windows-specific process info stubs (get_process_info_windows.c) - Add Windows system info implementation (info_messages_windows.c) - Update CMake build system to support Windows (MinGW/MSYS2) - Add build scripts and documentation for Windows native builds - Include helper scripts for WSL2 and MSYS2 build environments - Create minimal NVML header stub for compilation without CUDA Toolkit - Successfully tested on Windows 11 with NVIDIA RTX GPUs Changes maintain full backward compatibility with Linux builds.
- Fix WiX source paths to use ProjectRoot variable for proper file resolution - Update build-msi.ps1 to pass ProjectRoot to WiX compiler - Add make-release-packages.ps1 script to automate ZIP and MSI generation - Update winget manifest structure (SHA256 will be added after MSI build)
- Create build-msi-workaround.ps1 for WiX 6.x COM errors * Method 1: COM+ catalog reset (requires admin) * Method 2: Windows Installer service reinitialization * Method 3: Isolated temp directory build (proven solution) * Method 4: Alternative suggestions - Successfully build MSI using isolated temp directory method - Update winget manifest with SHA256: 8A460E6F88A1E00DFB24003B367F4BFF5DC0F217547A3C7AC91566137B6A6C40 - Update .gitignore to exclude MSI build artifacts - Update make-release-packages.ps1 for better MSI handling Fixes WiX 6.x COM initialization error (0x80004005) that prevented MSI builds. The workaround uses -intermediatefolder with unique temp paths to bypass COM initialization issues. MSI Package: nvtop-3.3.0-x64.msi (0.68 MB) WinGet manifest validated successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVTOP Windows Port - Feature-Complete Implementation
Overview
This is a comprehensive Windows port of Syllo/nvtop with extensive enhancements for multi-vendor GPU support, improved user experience, and production-ready deployment capabilities.
Version: 3.3.0
Base: nvtop 3.2.0
Branch:
windowsStatistics: 59 files changed, 8,251 insertions(+), 119 deletions(-)
🎯 Major Features
1. Native Windows Support
2. Multi-Vendor GPU Support
NVIDIA GPUs (via NVML)
AMD GPUs (NEW - via DXGI/PDH)
Intel GPUs (NEW - via DXGI/PDH)
3. Enhanced Visual Features
Dynamic Color-Coded Utilization Bars
4. Performance Optimizations
📁 Project Organization
New Directory Structure
🔧 Technical Implementation
Windows API Integration
Architecture Highlights
struct gpu_vendorcallbackswindows_compat.cprovides POSIX-like APIs📊 Feature Parity Matrix
🚀 Build System
Multiple Build Methods
Native MinGW/MSYS2 (recommended)
scripts/build-windows-native.ps1 -AllWSL2 (Linux-compatible)
Docker (cross-platform)
docker-compose up --buildPrerequisites Management
check-prerequisites.bat)install-deps-msys2.sh)make-standalone.ps1)📚 Documentation
Comprehensive Guides (4,500+ lines)
QUICKSTART_WINDOWS.md- Get running in 5 minutesPARITY_IMPROVEMENTS_SUMMARY.md- All v3.3.0 enhancementsSECURITY_COMPLIANCE_AUDIT.md- Security review and compliance🔐 Security Enhancements
LOAD_LIBRARY_SEARCH_SYSTEM32flag🎨 User Experience Improvements
📦 New Files Added
Source Code (7 files, ~2,500 lines)
get_process_info_windows.c(185 lines)info_messages_windows.c(54 lines)windows_compat.c(implementation)windows_compat.h(73 lines header)Documentation (12 files, ~3,500 lines)
Scripts (13 files, ~1,400 lines)
Tests (3 files, ~400 lines)
🔄 Compatibility
Windows Versions
GPU Requirements
Build Requirements
🎯 Use Cases
🚧 Known Limitations
All limitations are gracefully handled with "N/A" display.
📈 Performance Impact
🤝 Upstream Compatibility
This port maintains compatibility with upstream nvtop:
Can be merged upstream with minimal conflicts.
📝 Version History
🎉 Summary
This Windows port transforms nvtop from a Linux-only NVIDIA tool into a cross-platform, multi-vendor GPU monitoring solution with production-ready features, comprehensive documentation, and optimized performance. It's ready for mainstream use and potential upstream integration.
Total Contribution: 8,251 lines of new code, documentation, and tooling across 59 files.
For more details, see the comprehensive documentation in the docs directory.