Skip to content

Commit 611889d

Browse files
4.1.1 (#82)
* Bump Android SDK to 4.1.1, replace event listeners to use new API, package version update to 4.1.1 * AGP backward compatiblity * README update
1 parent f7b22e1 commit 611889d

File tree

7 files changed

+35
-10
lines changed

7 files changed

+35
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ allprojects {
4949
```javascript
5050
import Survicate, {UserTrait} from '@survicate/react-native-survicate';
5151

52-
Survicate.initialize();
52+
Survicate.initializeSdk();
5353
Survicate.invokeEvent("eventName");
5454
Survicate.enterScreen("screenName");
5555
Survicate.leaveScreen("screenName");
@@ -66,7 +66,7 @@ const listener: SurvicateEventListener = {
6666
onSurveyClosed(event: SurveyClosedEvent) {},
6767
onSurveyCompleted(event: SurveyCompletedEvent) {},
6868
}
69-
Survicate.addSurvicateEventListener(listener);
69+
const subscription = Survicate.addSurvicateEventListener(listener);
7070
Survicate.reset();
7171
```
7272

android/build.gradle

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,29 @@ if (isNewArchitectureEnabled()) {
4646
apply plugin: 'com.facebook.react'
4747
}
4848

49+
def supportsNamespace() {
50+
def parsed = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')
51+
def major = parsed[0].toInteger()
52+
def minor = parsed[1].toInteger()
53+
54+
// Namespace support was added in 7.3.0
55+
if (major == 7 && minor >= 3) {
56+
return true
57+
}
58+
59+
return major >= 8
60+
}
61+
4962
android {
50-
namespace "com.survicate.react"
63+
if (supportsNamespace()) {
64+
namespace "com.survicate.react"
65+
66+
sourceSets {
67+
main {
68+
manifest.srcFile "src/main/AndroidManifestNew.xml"
69+
}
70+
}
71+
}
5172
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
5273
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)
5374
defaultConfig {
@@ -99,7 +120,7 @@ repositories {
99120
dependencies {
100121
//noinspection GradleDynamicVersion
101122
implementation 'com.facebook.react:react-native:+' // From node_modules
102-
implementation ('com.survicate:survicate-sdk:4.1.0')
123+
implementation ('com.survicate:survicate-sdk:4.1.1')
103124
}
104125

105126
if (isNewArchitectureEnabled()) {
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1-
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
1+
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2+
package="com.survicate.react">
23

34
</manifest>
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
2+
3+
</manifest>

android/src/main/java/com/survicate/react/SurvicateModuleImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void setWorkspaceKey(String workspaceKey) {
7575
@ReactMethod
7676
public void addListener(String eventName) {
7777
if (listenerCount == 0) {
78-
Survicate.setEventListener(eventListener);
78+
Survicate.addEventListener(eventListener);
7979
}
8080

8181
listenerCount++;
@@ -86,7 +86,7 @@ public void removeListeners(int count) {
8686
listenerCount -= count;
8787

8888
if (listenerCount == 0) {
89-
Survicate.setEventListener(null);
89+
Survicate.removeEventListener(eventListener);
9090
}
9191
}
9292

ios/SurvicateBindings.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ - (dispatch_queue_t)methodQueue
6666

6767
- (void)startObserving {
6868
hasListeners = YES;
69-
[[SurvicateSdk shared] setDelegate:self];
69+
[[SurvicateSdk shared] addListener:self];
7070
}
7171

7272
- (void)stopObserving {
7373
hasListeners = NO;
74-
[[SurvicateSdk shared] setDelegate:nil];
74+
[[SurvicateSdk shared] removeListener:self];
7575
}
7676

7777
- (void)surveyDisplayedWithEvent:(SurveyDisplayedEvent * _Nonnull)event {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@survicate/react-native-survicate",
33
"title": "React Native Survicate Bindings",
4-
"version": "4.1.0",
4+
"version": "4.1.1",
55
"description": "React Native bindings for Survicate Mobile SDK",
66
"main": "lib/commonjs/index.js",
77
"module": "lib/module/index.js",

0 commit comments

Comments
 (0)