Skip to content

Conversation

@sumo-drosiek
Copy link
Contributor

This PR contains the following changes:

  • add short flag a to drop-rate, because of build errors
  • add /otCollectors/metadata endpoint
  • add /collector/{logs,metrics,traces} endpoint referring to router::otlp
  • rename CollectorRegisterRespone serialization keys
  • add support for Bearer authorization

I'm considering the following changes:

  • rename CollectorRegisterRespone properties instead of renaming it during serialization
  • drop support for Basic authorization

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner May 25, 2023 14:18
Copy link
Contributor

@aboguszewski-sumo aboguszewski-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you leave a link with documentation to this API somewhere in this PR?

@sumo-drosiek
Copy link
Contributor Author

LGTM, could you leave a link with documentation to this API somewhere in this PR?

Is there any public documentation? I was reverse-engineering 🙈

@sumo-drosiek sumo-drosiek force-pushed the drosiek-collector-api branch from 0f8332c to 786f693 Compare May 25, 2023 15:03
@aboguszewski-sumo
Copy link
Contributor

Then leave it 😔

@sumo-drosiek sumo-drosiek merged commit 46964c6 into main May 26, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-collector-api branch May 26, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants