Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Jul 29, 2019

This should fix failure (inadvertently) introduced in #176.

After that change, tests started failing with:

root@pkg-e2e-test-ubuntu18-pr-st2-10491:/home/stanley# st2 execution get 5d3f461ca17deb590fa6fec8
id: 5d3f461ca17deb590fa6fec8
status: failed (1s elapsed)
parameters: 
  cmd: st2-run-pack-tests -p /opt/stackstorm/packs/xml=0.3.0
  env:
    ST2_API_URL: http://127.0.0.1:9101
    ST2_AUTH_TOKEN: 7d4e6fc9c674436bbd0088eee8dc8df0
    ST2_AUTH_URL: http://127.0.0.1:9100
    ST2_BASE_URL: http://127.0.0.1
  timeout: 180
result: 
  failed: true
  return_code: 3
  stderr: ''
  stdout: 'Invalid pack path: /opt/stackstorm/packs/xml=0.3.0'

The problem is that invalid argument is passed to st2-run-pack-tests tool. This tool expects just a pack name without a version.

See #176 (comment) for more context.

@Kami Kami requested a review from jinpingh July 29, 2019 19:24
@Kami
Copy link
Member Author

Kami commented Jul 29, 2019

@jinpingh in the future, it would be great if you could test your changes / branch with end to end tests before merging it into master :)

Copy link
Contributor

@bigmstone bigmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kami Kami added this to the 3.2.0 milestone Jul 29, 2019
Copy link
Contributor

@jinpingh jinpingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix it. When i test it on my dev machine, modified workflow for simplicity in order for try out fix. After that forgot to test entire workflow.

@Kami
Copy link
Member Author

Kami commented Jul 29, 2019

Next time to test it end to end, you can use st2tests_branch parameter of st2cd.e2e_tests action.

@Kami
Copy link
Member Author

Kami commented Jul 29, 2019

Confirmed it's working end to end (sigh, this took way to long). Merging.

Child execution (task=test_quickstart_pack_install_tool) 5d3f54940dfc1872598c3c35 has finished (status=succeeded).

@Kami Kami merged commit 1b343f1 into master Jul 29, 2019
@Kami Kami deleted the fix_failing_tests branch July 29, 2019 20:30
@Kami
Copy link
Member Author

Kami commented Oct 29, 2019

So #177 also broke self check which relies all the actions in tests/ pack taking protocol and hostname parameter.

NOTE: All the tests which are added to this pack automatically run when running st2-self-check and need to follow a specific format (each action needs to take host, port and token parameter, etc).

Fix likely involves moving that action to a different pack or refactoring it to work with those parameters.

Kami added a commit that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants