-
Notifications
You must be signed in to change notification settings - Fork 12
Fix failure introduced in #176 #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jinpingh in the future, it would be great if you could test your changes / branch with end to end tests before merging it into master :) |
bigmstone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fix it. When i test it on my dev machine, modified workflow for simplicity in order for try out fix. After that forgot to test entire workflow.
|
Next time to test it end to end, you can use |
|
Confirmed it's working end to end (sigh, this took way to long). Merging. Child execution (task=test_quickstart_pack_install_tool) 5d3f54940dfc1872598c3c35 has finished (status=succeeded). |
|
So #177 also broke self check which relies all the actions in
Fix likely involves moving that action to a different pack or refactoring it to work with those parameters. |
This should fix failure (inadvertently) introduced in #176.
After that change, tests started failing with:
root@pkg-e2e-test-ubuntu18-pr-st2-10491:/home/stanley# st2 execution get 5d3f461ca17deb590fa6fec8 id: 5d3f461ca17deb590fa6fec8 status: failed (1s elapsed) parameters: cmd: st2-run-pack-tests -p /opt/stackstorm/packs/xml=0.3.0 env: ST2_API_URL: http://127.0.0.1:9101 ST2_AUTH_TOKEN: 7d4e6fc9c674436bbd0088eee8dc8df0 ST2_AUTH_URL: http://127.0.0.1:9100 ST2_BASE_URL: http://127.0.0.1 timeout: 180 result: failed: true return_code: 3 stderr: '' stdout: 'Invalid pack path: /opt/stackstorm/packs/xml=0.3.0'The problem is that invalid argument is passed to
st2-run-pack-teststool. This tool expects just a pack name without a version.See #176 (comment) for more context.