-
Notifications
You must be signed in to change notification settings - Fork 12
Fix broken st2-self-check script #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
used directly for end to end and st2-self-check tests.
|
Confirmed it's working: Deleting 'st2tests' directory from /home/ubuntu.
~
Attempting Test tests.test_inquiry_chain...OK! (47s)
Attempting Test tests.test_inquiry_mistral...OK! (49s)
Attempting Test tests.test_key_triggers...OK! (33s)
Attempting Test tests.test_pack_install_tool...OK! (10s)
Attempting Test tests.test_packs_pack...OK! (76s)
Attempting Test tests.test_quickstart...OK! (21s)
Attempting Test tests.test_quickstart_key...OK! (6s)
Attempting Test tests.test_quickstart_local_script_actions...OK! (13s)
Attempting Test tests.test_quickstart_passive_sensor...OK! (7s)
Attempting Test tests.test_quickstart_polling_sensor...OK! (4s)
Attempting Test tests.test_quickstart_python_actions...OK! (11s)
Attempting Test tests.test_quickstart_remote_script_actions...OK! (14s)
Attempting Test tests.test_quickstart_rules...OK! (62s)
Attempting Test tests.test_quickstart_trace...OK! (16s)
Attempting Test tests.test_render_config_context...OK! (5s) |
|
@Kami Not sure how it is working for moving If action is moved to |
Yeah, I've fixed that locally already, but haven't pushed the changes yet - I've pushed them now. I will look into the StackStorm/st2 change - one option would be to simply move that action to the examples pack (IIRC, we already have a similar action there). |
|
I've pushed latest changes. Per our discussion on Slack, I moved action to fixtures pack StackStorm/st2#4625. |
This pull request fixes an issue introduced in #150 which I described here - #150 (comment).
testspack is only used for end to end and st2-self-check script tests. As such, all the actions inside that pack should follow that action format.To fix the issue, I made the following changes:
fixturespack - that's where "fixture" actions should livetests.test_render_config_contextaction which uses the fixture action and tests render config context functionalityThis will also require changed in StackStorm/st2 repo. We can likely get rid of all the "clone st2tests" pack change from this PR - StackStorm/st2#4567.