Skip to content

Commit baf9e8f

Browse files
authored
Merge pull request #98 from StackStorm/upgrade_pip
Upgrade pip to 20.3.3 and virtualenv to 20.4.0
2 parents a70cf56 + 3b21c8f commit baf9e8f

File tree

5 files changed

+28
-10
lines changed

5 files changed

+28
-10
lines changed

packagingbuild/bionic/Dockerfile

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,26 @@ RUN apt-get update && \
4747
devscripts debhelper dh-make libldap2-dev libsasl2-dev && apt-get clean
4848

4949
# Install fresh pip and co
50-
RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 - virtualenv==16.6.0 pip==20.0.2 wheel setuptools cryptography; \
50+
RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 - virtualenv==20.4.0 pip==20.3.3 wheel setuptools cryptography; \
5151
pip3.6 install --upgrade requests[security] && rm -rf /root/.cache
5252

53-
# We use our dh-virtualenv version, since it fixes shebangd lines rewrites
53+
# This line just busts Docker's cache so it re-runs the next line
54+
# The GitHub API will return different results when the branch HEAD changes
55+
# See https://stackoverflow.com/a/39278224
56+
# ADD https://api.github.com/repos/StackStorm/dh-virtualenv/git/refs/heads/stackstorm_patched version.json
57+
# RUN rm version.json
58+
#
59+
# We use our dh-virtualenv version, since it fixes shebangd lines rewrites.
60+
# The shebangd rewrites are in master branch, but that requires dependency
61+
# on debhelper 12.
62+
#
5463
RUN apt-get -y install \
5564
python-virtualenv python-setuptools python-mock && \
5665
apt-get clean && \
57-
git clone --branch stackstorm_patched_use_custom_pip https://github.com/StackStorm/dh-virtualenv.git /tmp/dh-virtualenv && \
66+
git clone --branch stackstorm_patched https://github.com/StackStorm/dh-virtualenv.git /tmp/dh-virtualenv && \
5867
cd /tmp/dh-virtualenv && \
5968
dpkg-buildpackage -b -uc -us && dpkg -i ../dh-virtualenv_*.deb && \
60-
rm -rf /tmp/dh-virtualenv*
69+
rm -rf /tmp/dh-virtualenv*
6170
RUN apt-get -y install dh-systemd && apt-get clean
6271

6372
VOLUME ['/home/busybee/build']

packagingbuild/centos7/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ RUN yum -y install nc net-tools
7979
RUN yum -y install rpmdevtools epel-release
8080
# Install python3
8181
RUN yum -y install python3 python3-devel python3-virtualenv && \
82-
pip3 install virtualenv==16.6.0 pip==20.0.2 wheel setuptools
82+
pip3 install virtualenv==20.4.0 pip==20.3.3 wheel setuptools
8383
RUN pip3 install --upgrade requests[security] venvctrl && rm -rf /root/.cache
8484

8585
VOLUME ["/home/busybee/build"]

packagingbuild/centos8/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ RUN yum -y install nc net-tools
8787

8888
# Install development tools and python3 for EL8
8989
RUN yum -y install python3 python3-devel rpmdevtools python3-virtualenv && \
90-
pip3 install virtualenv==16.6.0 pip==20.0.2 wheel setuptools
90+
pip3 install virtualenv==20.4.0 pip==20.3.3 wheel setuptools
9191

9292
RUN pip3 install requests[security] venvctrl --upgrade && rm -rf /root/.cache
9393

packagingbuild/xenial/Dockerfile

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,23 @@ RUN apt-get update && \
5353
devscripts debhelper dh-make libldap2-dev libsasl2-dev && apt-get clean
5454

5555
# Install fresh pip and co
56-
RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 - virtualenv==16.6.0 pip==20.0.2 wheel setuptools; \
56+
RUN curl https://bootstrap.pypa.io/get-pip.py | python3.6 - virtualenv==20.4.0 pip==20.3.3 wheel setuptools; \
57+
5758
pip3.6 install --upgrade requests[security] && rm -rf /root/.cache
5859

60+
# This line just busts Docker's cache so it re-runs the next line
61+
# The GitHub API will return different results when the branch HEAD changes
62+
# See https://stackoverflow.com/a/39278224
63+
# ADD https://api.github.com/repos/StackStorm/dh-virtualenv/git/refs/heads/stackstorm_patched version.json
64+
# RUN rm version.json
65+
5966
# We use our dh-virtualenv version, since it fixes shebangd lines rewrites
6067
RUN apt-get -y install \
61-
python-virtualenv python-setuptools python-mock && \
68+
python-virtualenv \
69+
python-setuptools \
70+
python-mock && \
6271
apt-get clean && \
63-
git clone --branch stackstorm_patched_use_custom_pip https://github.com/StackStorm/dh-virtualenv.git /tmp/dh-virtualenv && \
72+
git clone --branch stackstorm_patched https://github.com/StackStorm/dh-virtualenv.git /tmp/dh-virtualenv && \
6473
cd /tmp/dh-virtualenv && \
6574
dpkg-buildpackage -b -uc -us && dpkg -i ../dh-virtualenv_*.deb && \
6675
rm -rf /tmp/dh-virtualenv*

packagingtest/centos7/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ RUN yum -y install \
1212
openssh \
1313
subversion \
1414
setup
15-
15+
1616
# Build tools
1717
RUN yum -y install \
1818
autoconf \

0 commit comments

Comments
 (0)