Skip to content

Conversation

@blag
Copy link
Contributor

@blag blag commented Jul 27, 2021

This PR updates the Makefile to use Python 3's venv module, and it fixes a few oversights made when adding black.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Jul 27, 2021
@blag blag added this to the 3.6.0 milestone Jul 27, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The packaging is heavily relying on the virtualenv and so the tooling consistency is the first idea that came to my mind here.

But what is our motivation behind replacing virtualenv with venv at least for the Makefile?

@blag
Copy link
Contributor Author

blag commented Jul 30, 2021

I believe that the virtualenv executable is going to go away in future versions of official Python releases 1 and the venv module will be the primary way to create virtualenvs.

Now that we're only supporting ST2 on Python 3, we should always have the venv module, and we should migrate to that before it breaks our CI process and becomes an emergency.

1 While I'm sure somebody in the Python community will create and maintain a virtualenv executable, I don't think this is something that we should rely on long term.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2021

CLA assistant check
All committers have signed the CLA.

@winem
Copy link
Contributor

winem commented Sep 10, 2021

How do we want to proceed here? I see the point and am a big fan of tooling consistency but @blag has a very good point and I don't see any real risk in switching to venv.

Is there anything else that may help to make a final decision?

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Forgot to follow up on this.

@cognifloyd cognifloyd enabled auto-merge October 2, 2021 01:30
@cognifloyd cognifloyd merged commit d56c3d4 into master Oct 2, 2021
@cognifloyd cognifloyd deleted the update-makefile branch October 2, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix enhancement python3 size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants