Skip to content

Commit d496c0f

Browse files
committed
Address code review comment - Add '"' for keywords in error message
PR #4709
1 parent 2a00552 commit d496c0f

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

st2common/st2common/util/pack.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@ def validate_config_against_schema(config_schema, config_object, config_path,
107107
for key in config_object:
108108
if (jinja_utils.is_jinja_expression(value=config_object.get(key)) and
109109
"decrypt_kv" in config_object.get(key) and config_schema.get(key).get('secret')):
110-
raise ValueValidationException('Values specified as secret: True in config schema '
110+
raise ValueValidationException('Values specified as "secret: True" in config schema '
111111
'are automatically decrypted by default. Use of '
112-
'decrypt_kv jinja filter is not allowed for such '
112+
'"decrypt_kv" jinja filter is not allowed for such '
113113
'values.')
114114

115115
schema = util_schema.get_schema_for_resource_parameters(parameters_schema=config_schema,

st2common/tests/unit/test_configs_registrar.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,9 @@ def test_register_all_configs_with_config_schema_validation_validation_failure_3
168168
registrar._register_pack(pack_name='dummy_pack_11', pack_dir=PACK_11_PATH)
169169
packs_base_paths = content_utils.get_packs_base_paths()
170170

171-
expected_msg = ('Values specified as secret: True in config schema '
172-
'are automatically decrypted by default. Use of '
173-
'decrypt_kv jinja filter is not allowed for such '
174-
'values.')
171+
expected_msg = ('Values specified as "secret: True" in config schema are automatically '
172+
'decrypted by default. Use of "decrypt_kv" jinja filter is not allowed '
173+
'for such values.')
175174

176175
self.assertRaisesRegexp(ValueError, expected_msg,
177176
registrar.register_from_packs,

0 commit comments

Comments
 (0)