Implement LDAP backend #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
any reason these aren't enum'd (BASE/ONE/SUB)?
Contributor
Author
There was a problem hiding this comment.
yeah, i will change that.
|
Nice and clean. 👍 |
m4dcoder
force-pushed
the
ldap_backend
branch
from
60e1fe4 to
6b45914
Compare
m4dcoder
force-pushed
the
ldap_backend
branch
from
6b45914 to
1ddb597
Compare
Member
There was a problem hiding this comment.
Would be good if we can make this configurable for debugging purposes.
Maybe you could allow user to define debug argument and if this argument is specified, set this option to an appropriate value and also pass trace_level argument with the appropriate value to the initialize method.
Member
|
Just FYI - I've enabled (private) Travis CI for this repo - https://magnum.travis-ci.com/StackStorm/st2-enterprise-auth-backend-ldap |
Member
|
I've added some comments, but overall +1 on what @jfryman has said - nice and clean 👍 |
Kami
added a commit
that referenced
this pull request
May 7, 2019
73fe88f Fix merge conflict. 72d3b7c Merge pull request #1 from StackStorm/update_lint_configs 2709c47 Update lint config with changes from StackStorm/st2#4657. 418d2eb Sync flake8 config with StackStorm/st2 master. 9b6b10b Update flake8 config so we ignore build/ and dist/ directories. e43b03a Update pylint config. git-subtree-dir: lint-configs git-subtree-split: 73fe88f2da7403d69bc5ebd7c6d22d12860c3744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.