SQ Plugin: Should align logging for not indexed files #9571
Conversation
Tim-Pohlmann
requested review from
andrei-epure-sonarsource and
zsolt-kolbay-sonarsource
|
@andrei-epure-sonarsource I assigned you as a secondary reviewer. Please confirm that the PR solves the issue. |
...dotnet-shared-library/src/main/java/org/sonar/plugins/dotnet/tests/DotCoverReportParser.java
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
changed the title
...r-dotnet-shared-library/src/main/java/org/sonar/plugins/dotnet/tests/ScannerFileService.java
Outdated
Show resolved
Hide resolved
| assertThat(logTester.logs(Level.DEBUG).get(0)).isEqualTo("Did not find deterministic source path in 'C:\\_\\some\\path\\file.cs'." + | ||
| " Will skip this coverage entry. Verify sonar.sources in .sonarqube\\out\\sonar-project.properties."); | ||
| assertThat(logTester.logs(Level.DEBUG).get(0)).isEqualTo( | ||
| "The file 'C:\\_\\some\\path\\file.cs' is not indexed or does not have the supported language." |
There was a problem hiding this comment.
this can fail either because there is a mismatch between the deterministic source path (due to some tooling issue) or because the file hasn't been indexed.
how can we make both possible cases clear? is it worth it? what would it help if you were the developer investigating such a case?
Did you look at the integration tests we have for deterministic code coverage, to get more context?
There was a problem hiding this comment.
I refactored it a bit to improve the situation. I hope the messages make sense now.
Tim-Pohlmann
force-pushed
the
Tim/AlignLogging
branch
from
5e8e9f0 to
225ea37
Compare
Tim-Pohlmann
force-pushed
the
Tim/AlignLogging
branch
from
225ea37 to
60d5774
Compare
zsolt-kolbay-sonarsource
left a comment
zsolt-kolbay-sonarsource
left a comment
There was a problem hiding this comment.
LGTM! Left one remark.
...tnet-shared-library/src/test/java/org/sonar/plugins/dotnet/tests/ScannerFileServiceTest.java
Outdated
Show resolved
Hide resolved
Tim-Pohlmann
force-pushed
the
Tim/AlignLogging
branch
from
f9968c3 to
70cf878
Compare
|
|
3 participants
Fixes #8503