fix quality flaws #988
Merged
fix quality flaws #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bertk
commented
Oct 30, 2016
Bertk
commented
- different license headers
- method needlessly boxes a boolean constant
- concatenates the result of a toString()
- passes constant String of length 1 to character overridden method
- string literal on the left side of this string comparison
- Assertions should be complete
- different license headers - method needlessly boxes a boolean constant - concatenates the result of a toString() - passes constant String of length 1 to character overridden method - string literal on the left side of this string comparison - Assertions should be complete
Collaborator
guwirth
reviewed
Nov 1, 2016
| AddMacro("_ATL_VER=0x0C00", fileElement); | ||
| } | ||
| } | ||
| /* |
Collaborator
There was a problem hiding this comment.
@jmecosta: file CxxVCppBuildLogParser.java, this is a bigger change (at least in LOC): also ok for you?
Member
There was a problem hiding this comment.
Seems to be only line endig fixing. Seems ok
Member
There was a problem hiding this comment.
Seems to be only line endig fixing. Seems ok
Member
There was a problem hiding this comment.
Seems to be only line endig fixing. Seems ok
Collaborator
|
Will merge this because a lot of files are changed. Risk to get merge conflicts if I delay it. @jmecosta if there are problems we have to fix it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.